Included aistack test call #20384
Included aistack test call #20384
Conversation
yarunachalam
commented
Oct 11, 2024
yarunachalam
commented
- Verification run: not ready to test
yarunachalam
requested review from
pdostal,
grisu48,
asmorodskyi and
ricardobranco777
as code owners
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
lib/main_publiccloud.pm
Outdated
| } elsif (get_var('PUBLIC_CLOUD_AISTACK')) { | ||
| my $args = OpenQA::Test::RunArgs->new(); | ||
| loadtest('publiccloud/upload_image', run_args => $args); | ||
| loadtest('publiccloud/aistack', run_args => $args); |
There was a problem hiding this comment.
You forgot to include this module.
There was a problem hiding this comment.
Indeed,aistack.pm missing
There was a problem hiding this comment.
Im confused. Im loading test for publiccloud/aistack. Which is another PR https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/20015/files
There was a problem hiding this comment.
Why not add all this code in the other PR? Why do you want to have separate PR's? =/
There was a problem hiding this comment.
ah then you have before to merge the pr 20015, for that module, this 20384 needs for it.
But indeed, that PR change has no load-module call to use it, you cannot test it that way. It is like a new routine, nowhere called-used.
As above suggested, this PR updates, calling ai module, better if moved/added into it.
yarunachalam
force-pushed
the
aistackcall
branch
from
ad973d4
to
a5900da
Compare
