Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nits in Python tests causing build failure #4400

Merged
merged 2 commits into from
Aug 22, 2023
Merged

fix nits in Python tests causing build failure #4400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de5003d
fix nits causing build failure
vladak Aug 22, 2023
6798777
remove oldC check
vladak Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions opengrok-indexer/src/test/java/org/opengrok/indexer/util/CtagsUtilTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ void getLanguages() {
assertNotNull(result, "getLanguages() should always return non null");
assertFalse(result.isEmpty(), "should get Ctags languages");
assertTrue(result.contains("C++"), "Ctags languages should contain C++");
// Test that the [disabled] tag is stripped for OldC.
assertTrue(result.contains("OldC"), "Ctags languages should contain OldC");
}

@Test
Expand Down
4 changes: 2 additions & 2 deletions tools/src/test/python/test_readconfig.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
#

#
# Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.
# Copyright (c) 2021, 2023, Oracle and/or its affiliates. All rights reserved.
#
import os
import tempfile
Expand All @@ -37,5 +37,5 @@ def test_read_config_empty_yaml():
res = read_config(mock(spec=logging.Logger, strict=False), tmpf.name)
os.remove(tmpf.name)
assert res is not None
assert type(res) == dict
assert type(res) is dict
assert len(res) == 0
4 changes: 2 additions & 2 deletions tools/src/test/python/test_restful.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
#

#
# Copyright (c) 2019, 2022, Oracle and/or its affiliates. All rights reserved.
# Copyright (c) 2019, 2023, Oracle and/or its affiliates. All rights reserved.
#

import pytest
Expand All @@ -30,7 +30,7 @@

from mockito import verify, patch, mock

from opengrok_tools.utils.restful import call_rest_api,\
from opengrok_tools.utils.restful import call_rest_api, \
CONTENT_TYPE, APPLICATION_JSON, do_api_call
from opengrok_tools.utils.commandsequence import ApiCall

Expand Down
Loading