Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nits in Python tests causing build failure #4400

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

vladak
Copy link
Member

@vladak vladak commented Aug 22, 2023

Fixes the problem recently surfacing during Linux builds:

[INFO] --- exec:1.6.0:exec (Python flake8) @ tools ---
flake8.checker            MainProcess     93 INFO     Making checkers
flake8.main.application   MainProcess    756 INFO     Finished running
flake8.main.application   MainProcess    756 INFO     Reporting errors
flake8.main.application   MainProcess    757 INFO     Found a total of 13 violations and reported 2
/home/runner/work/opengrok/opengrok/tools/src/test/python/test_readconfig.py:40:12: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
/home/runner/work/opengrok/opengrok/tools/src/test/python/test_restful.py:33:55: E231 missing whitespace after ','
Error:  Command execution failed.

Also, remove the OldC ctags test. That parser was removed in Universal ctags in universal-ctags/ctags@4c7738d

@vladak vladak added the tools Python tools label Aug 22, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 22, 2023
ctags --list-languages no longer contains it
@vladak vladak merged commit 93694f5 into oracle:master Aug 22, 2023
8 of 9 checks passed
@vladak vladak deleted the python_test_nits branch August 22, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement. tools Python tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant