Seed image format version OCI image label #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
donpenney
reviewed
Dec 19, 2023
omertuc
force-pushed
the
seedformat
branch
2 times, most recently
from
de72c02
to
81b46a2
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
donpenney
reviewed
Jan 2, 2024
controllers/prep_handlers.go
Outdated
| // the imager during the image build process, and is only manually bumped by | ||
| // developers when the image format changes in a way that is incompatible with | ||
| // previous versions of the lifecycle-agent. | ||
| func (r *ImageBasedUpgradeReconciler) checkSeedImageCompatibility(ctx context.Context, pullSecretFilename string, seedImageRef string) error { |
There was a problem hiding this comment.
Linter is failing:
Suggested change
| func (r *ImageBasedUpgradeReconciler) checkSeedImageCompatibility(ctx context.Context, pullSecretFilename string, seedImageRef string) error { | |
| // | |
| //nolint:unparam | |
| func (r *ImageBasedUpgradeReconciler) checkSeedImageCompatibility(ctx context.Context, pullSecretFilename, seedImageRef string) error { |
donpenney
reviewed
Jan 2, 2024
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
omertuc
force-pushed
the
seedformat
branch
2 times, most recently
from
7feb363
to
e9defd5
Compare
donpenney
reviewed
Jan 2, 2024
|
/hold until testing is complete |
openshift-ci
bot
added
the
do-not-merge/hold
IBU reconciler now has a `checkSeedImageCompatibility` method that checks if the seed image is compatible with the current version of the lifecycle-agent. It does so by inspecting the OCI image's labels and checking if the specified format version equals the hard-coded one that this version of the lifecycle agent expects. That format version is set by the imager during the image build process, and is only manually bumped by developers when the image format changes in a way that is incompatible with previous versions of the lifecycle-agent.
|
Tested /unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: browsell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IBU reconciler now has a
checkSeedImageCompatibilitymethod thatchecks if the seed image is compatible with the current version of the
lifecycle-agent. It does so by inspecting the OCI image's labels and
checking if the specified format version equals the hard-coded one that
this version of the lifecycle agent expects. That format version is set
by the imager during the image build process, and is only manually
bumped by developers when the image format changes in a way that is
incompatible with previous versions of the lifecycle-agent.