Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing mirror registry in case seed registry is part of mirror configuration sources #202

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

tsorya
Copy link
Contributor

@tsorya tsorya commented Jan 3, 2024

No description provided.

@openshift-ci openshift-ci bot requested review from eranco74 and leo8a January 3, 2024 12:11
@donpenney
Copy link
Collaborator

Now that we have a compatibility version identifier with #188, does this PR need to increment the SeedFormatVersion value in internal/common/consts.go?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2024
Copy link
Contributor

openshift-ci bot commented Jan 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: donpenney

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 6b4b07a into openshift-kni:main Jan 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants