Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SA dashboards from 3.0 manifest #5154

Merged
merged 5 commits into from
Oct 29, 2024
Merged

Remove SA dashboards from 3.0 manifest #5154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9254ee8
Remove SA dashboards from 3.0 manifest
gaiksaya Oct 29, 2024
da37889
Add new line
gaiksaya Oct 29, 2024
c1c7cec
Comment
gaiksaya Oct 29, 2024
8fabf38
Comment
gaiksaya Oct 29, 2024
92c46db
fix
gaiksaya Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions jenkins/integ-test-notification.jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,7 @@ pipeline {
parameterizedCron('''
H */6 * * * %INPUT_MANIFEST=2.19.0/opensearch-2.19.0.yml
H */6 * * * %INPUT_MANIFEST=2.18.0/opensearch-2.18.0.yml
H */6 * * * %INPUT_MANIFEST=3.0.0/opensearch-3.0.0.yml
H */6 * * * %INPUT_MANIFEST=2.18.0/opensearch-dashboards-2.18.0.yml
H */6 * * * %INPUT_MANIFEST=3.0.0/opensearch-dashboards-3.0.0.yml
''')
}
parameters {
Expand Down
7 changes: 4 additions & 3 deletions manifests/3.0.0/opensearch-dashboards-3.0.0.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
- name: alertingDashboards
repository: https://github.com/opensearch-project/alerting-dashboards-plugin.git
ref: main
- name: securityAnalyticsDashboards
repository: https://github.com/opensearch-project/security-analytics-dashboards-plugin.git
Comment on lines -58 to -59
Copy link
Member

@peterzhuamazon peterzhuamazon Oct 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest comment it out instead of removing in case we forgot, you can add a line of comment about why.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

ref: main
# Commenting SA until https://github.com/opensearch-project/security-analytics-dashboards-plugin/issues/1185 is resolved

Check warning on line 58 in manifests/3.0.0/opensearch-dashboards-3.0.0.yml

View workflow job for this annotation

GitHub Actions / yaml-lint 

58:3 [comments-indentation] comment not indented like content
# - name: securityAnalyticsDashboards
# repository: https://github.com/opensearch-project/security-analytics-dashboards-plugin.git
# ref: main
Loading