Remove SA dashboards from 3.0 manifest #5154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sayali Gaikawad <[email protected]>
gaiksaya
requested review from
dblock,
peterzhuamazon,
rishabh6788,
zelinh,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
Signed-off-by: Sayali Gaikawad <[email protected]>
Comment on lines
-58
to
-59
| - name: securityAnalyticsDashboards | ||
| repository: https://github.com/opensearch-project/security-analytics-dashboards-plugin.git |
There was a problem hiding this comment.
Suggest comment it out instead of removing in case we forgot, you can add a line of comment about why.
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
peterzhuamazon
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Security-Analytics has been causing bootstrapping issues. See https://playground.nightly.opensearch.org/3x/app/login?
Opened an issue with the plugin team here opensearch-project/security-analytics-dashboards-plugin#1185
Tested locally and can see dashboards coming up without SA-Dashboards for 3.0.0
Also removed cronjob for 3.0.0 for integ-test notification as we are not running integ-test for 3.0.0 yet.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.