Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom commands options, rebase of PR #44 #157

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

geek-merlin
Copy link

Add options to custom commands. Rebase of #44.

@claudiu-cristea
Copy link
Contributor

claudiu-cristea commented Nov 11, 2021

I think we can add, along options, all that is missed for a command: description, aliases, usage. Or it would be too much for this PR?

@claudiu-cristea
Copy link
Contributor

Also, could you, please change the base branch to #44? Then I’ll merge it there so that we see the tests running (PRs from forks are not tested)

@geek-merlin
Copy link
Author

geek-merlin commented Nov 11, 2021

Oh that's great @claudiu-cristea that you chime in to this effort.

Yes, i'm willing to not only scratch my itch, but scratch thoroughly.

Also, could you, please change the base branch to #44?

I don't see anything like that as base branch choice, and don't think it works this way, or i understand it wrongly. Afaik github is not so friendly about different non-owners committing to a PR. Any idea? (EDIT: Maybe you add me to your fork or i add you to mine.)

@geek-merlin
Copy link
Author

As of features: Having thought about it, do we really want and need reverse inheritance of options? We can always pass any option value explicitly, and explicit is often better than implicit. Also code will be much simpler, so also need fewer tests.

@geek-merlin geek-merlin marked this pull request as ready for review November 11, 2021 23:48
@geek-merlin
Copy link
Author

geek-merlin commented Nov 11, 2021

Worksforme in some simple manual tests. Command description etc. is in.

I had to add SelfProcessingRoboConfig to make it possible to use option provided config in variables. Doing it with less magic would break BC, sigh.

@geek-merlin
Copy link
Author

Made some fixes and improvements, now using it happily in a complex deployment script.

@geek-merlin
Copy link
Author

Looks like the SelfUpdatingRoboConfig in this PR fixes or is related to #135.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants