-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom commands options, rebase of PR #44 #157
base: master
Are you sure you want to change the base?
Add custom commands options, rebase of PR #44 #157
Conversation
I think we can add, along options, all that is missed for a command: description, aliases, usage. Or it would be too much for this PR? |
Also, could you, please change the base branch to #44? Then I’ll merge it there so that we see the tests running (PRs from forks are not tested) |
Oh that's great @claudiu-cristea that you chime in to this effort. Yes, i'm willing to not only scratch my itch, but scratch thoroughly.
I don't see anything like that as base branch choice, and don't think it works this way, or i understand it wrongly. Afaik github is not so friendly about different non-owners committing to a PR. Any idea? (EDIT: Maybe you add me to your fork or i add you to mine.) |
As of features: Having thought about it, do we really want and need reverse inheritance of options? We can always pass any option value explicitly, and explicit is often better than implicit. Also code will be much simpler, so also need fewer tests. |
…riables in a BC way
Worksforme in some simple manual tests. Command description etc. is in. I had to add SelfProcessingRoboConfig to make it possible to use option provided config in variables. Doing it with less magic would break BC, sigh. |
Made some fixes and improvements, now using it happily in a complex deployment script. |
Looks like the SelfUpdatingRoboConfig in this PR fixes or is related to #135. |
Add options to custom commands. Rebase of #44.