ISAICP-5988: Command config cannot be overridden

[claudiu-cristea]

ISAICP-5988

Description

Each command class is able load configuration from a file by implementing AbstractCommands::getConfigurationFile() and returning a hardcoded file path. The method's docblock states:

/**
 * Path to YAML configuration file containing command defaults.
 */

But, unfortunately, these are not defaults because they cannot be overridden. Instead, the runner.yml.dist and runner.yml configs are overridden by values from the AbstractCommands::getConfigurationFile() file.

The first commit (1a4a840) of this PR proves the bug.

Proposal

• Don't process early the tokens.
• After commands from classes were discovered, merge config providers configuration on top of default configuration provided by commands and process the replacements.
• This should happen before the dynamic commands discovery and that discovery should benefit from the whole processed configuration.

Change log

• Added:
• Changed:
• Deprecated:
• Removed:
• Fixed:
• Security:

Commands

N/A

[geek-merlin]

It looks to me this is the same bug that i fixed in #157 via SelfProcessingRoboConfig. (There i thought i implemented a new feature that is needed as part of the base feature, but reading this, it looks like it's a bug that was there in the first place.)

[claudiu-cristea]

@geek-merlin I wonder what it's your opinion regarding my approach.

@ademarco This is a but that affects our project. Could you, please, take a look? It needs 2 approvals. Will get one from our team (Thanks!)