Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comprehensive tests for DataView #2383

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/odyssey-react-mui/src/Pagination/Pagination.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ const Pagination = ({
);

return variant === "paged" ? (
<PaginationContainer>
<PaginationContainer data-testId={`${variant}-pagination`}>
jordankoschei-okta marked this conversation as resolved.
Show resolved Hide resolved
<PaginationSegment odysseyDesignTokens={odysseyDesignTokens}>
<Box>
<Paragraph component="span" color="textSecondary">
Expand Down
2 changes: 2 additions & 0 deletions packages/odyssey-react-mui/src/labs/DataFilters.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -630,6 +630,7 @@ const DataFilters = ({
variant="primary"
endIcon={<CheckIcon />}
type="submit"
ariaLabel={t("filters.submit.label")}
/>
</AutocompleteOuterContainer>
)}
Expand Down Expand Up @@ -697,6 +698,7 @@ const DataFilters = ({
variant="primary"
endIcon={<CheckIcon />}
type="submit"
ariaLabel={t("filters.submit.label")}
/>
</Box>
)}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,8 @@ const StackContainer = styled("div", {
shouldForwardProp: (prop) =>
prop !== "odysseyDesignTokens" &&
prop !== "currentLayout" &&
prop !== "maxGridColumns",
prop !== "maxGridColumns" &&
prop !== "data-testid",
})<{
odysseyDesignTokens: DesignTokens;
currentLayout: CardLayout;
Expand Down Expand Up @@ -175,6 +176,7 @@ const CardLayoutContent = ({
odysseyDesignTokens={odysseyDesignTokens}
currentLayout={currentLayout}
maxGridColumns={cardLayoutOptions.maxGridColumns ?? 3}
data-testId={currentLayout}
>
{isLoading ? (
<LoadingContainer odysseyDesignTokens={odysseyDesignTokens}>
Expand Down
Loading