-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comprehensive tests for DataView #2383
Open
jordankoschei-okta
wants to merge
18
commits into
main
Choose a base branch
from
jk-dataview-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,231
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds test coverage for
DataView
, attempting to be comprehensive but not overwhelming.For simplicity, most of the tests use an example data set of 7 characters from Star Wars (7 being an easy enough number of items to reason about).
I've tried to avoid adding
data-testid
wherever possible, opting for implicit attributes likearia-label
instead. However, in a few circumstances, adding a test id was the most efficient route; in those cases, I useddata-testid
.Due to the way
DataView
loads data, I've needed to make heavy use ofwaitFor
andawait
to detect when the component is truly ready to be tested. In many instances, the tests were receiving a false positive that the table was ready, even though it was empty. I used a few different ways to validate that the test was ready, based on the circumstance:thead
row)List of tests
Display modes
Auxiliary controls
Table-specific options
Row selection
Row reordering
Row expansion
Additional states
Pagination