Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage: use ZMS for new RRAM devices #626

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Storage: use ZMS for new RRAM devices #626

merged 1 commit into from
Oct 21, 2024

Conversation

RobertGalatNordic
Copy link
Collaborator

@RobertGalatNordic RobertGalatNordic commented Oct 17, 2024 •
edited by ktaborowski
Loading

nrf54 has RRAM and therefore should use ZMS

CI parameters

Github_actions:
  #(branch, hash, pull/XXX/head)
  NRF_revision: pull/17994/head

  # Do not change after creating PR
  Create_NRF_PR: false
Jenkins:
  test-sdk-sidewalk: master

Description

JIRA ticket:

Self review

  • There is no commented code.
  • There are no TODO/FIXME comments without associated issue ticket.
  • Commits are properly organized.
  • Change has been tested.
  • Tests were updated (if applicable).

@github-actions github-actions bot added the source PR changing src files label Oct 17, 2024
@RobertGalatNordic
Storage: use ZMS for new RRAM devices
acfab38 
nrf54 has RRAM and therefore should use ZMS

Signed-off-by: Robert Gałat <[email protected]>
@github-actions github-actions bot added the tests label Oct 17, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 17, 2024 •
edited
Loading

Sample diff used total
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.dut RAM 1.02 KB 140.67 KB 0 B
ROM 1.43 KB 496.44 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.dut.no_secure RAM 1.02 KB 140.66 KB 0 B
ROM 1.43 KB 485.04 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello RAM 1.02 KB 118.15 KB 0 B
ROM 1.37 KB 442.25 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello.ble_only RAM 1.02 KB 91.44 KB 0 B
ROM 1.36 KB 345.96 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello.ble_only.release RAM 1.02 KB 86.66 KB 0 B
ROM 896 B 276.93 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello.release RAM 1.02 KB 102.05 KB 0 B
ROM 900 B 353.23 KB 0 B
thingy53/nrf5340/cpuapp:sample.sidewalk.demo.ble_only RAM 0 B 105.72 KB 0 B
ROM -40 B 336.08 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.demo RAM 0 B 117.68 KB 0 B
ROM -40 B 431.11 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.demo.ble_only RAM 0 B 102.35 KB 0 B
ROM -44 B 352.93 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.dut RAM 0 B 141.27 KB 0 B
ROM -40 B 494.99 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.dut.no_secure RAM 0 B 141.25 KB 0 B
ROM -40 B 486.45 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello RAM 0 B 118.85 KB 0 B
ROM -40 B 445.92 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.ble_only RAM 0 B 92.17 KB 0 B
ROM -40 B 351.18 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.ble_only.release RAM 0 B 87.36 KB 0 B
ROM -40 B 287.5 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.release RAM 0 B 102.7 KB 0 B
ROM -40 B 362.32 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.demo RAM 0 B 111.16 KB 0 B
ROM -40 B 375.91 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.demo.ble_only RAM 0 B 95.97 KB 0 B
ROM -40 B 296.62 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.dut RAM 0 B 134.87 KB 0 B
ROM -40 B 440.55 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.dut.no_secure RAM 0 B 134.85 KB 0 B
ROM -44 B 433.09 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello RAM 0 B 112.6 KB 0 B
ROM -40 B 391 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello.ble_only RAM 0 B 86.06 KB 0 B
ROM -40 B 295.1 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello.ble_only.release RAM 0 B 81.41 KB 0 B
ROM -44 B 229.29 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello.release RAM 0 B 96.59 KB 0 B
ROM -44 B 304.81 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.demo RAM 1.02 KB 116.77 KB 0 B
ROM 1.37 KB 427.66 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.demo.ble_only RAM 1.02 KB 101.39 KB 0 B
ROM 1.37 KB 347.73 KB 0 B

@tomi-font tomi-font mentioned this pull request Oct 18, 2024
Merged
ktaborowski
ktaborowski approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@ktaborowski ktaborowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please have a look at questions below

Kconfig.dependencies Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
tests/unit_tests/pal_storage_kv/testcase.yaml Show resolved Hide resolved
@NordicBuilder NordicBuilder mentioned this pull request Oct 18, 2024
Merged
@tomi-font
Copy link

FYI, integrating this in nrfconnect/sdk-nrf#17994.

@RobertGalatNordic RobertGalatNordic merged commit 34568df into nrfconnect:main Oct 21, 2024
56 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomi-font tomi-font tomi-font approved these changes

@totyz totyz totyz approved these changes

@ktaborowski ktaborowski ktaborowski approved these changes

@rlubos rlubos rlubos approved these changes

Assignees
No one assigned
Labels
source PR changing src files tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RobertGalatNordic @tomi-font @rlubos @ktaborowski @totyz