Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trusted_storage: switch to ZMS on nRF54L15 #17994

Merged

Conversation

tomi-font
Copy link
Contributor

And disallow NVS.

@tomi-font tomi-font requested review from a team as code owners October 18, 2024 07:20
@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Oct 18, 2024
@tomi-font tomi-font added the CI-all-test Run All integration tests label Oct 18, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 18, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
sidewalk nrfconnect/sdk-sidewalk@029f0cf nrfconnect/sdk-sidewalk@34568df (main) nrfconnect/[email protected]
zephyr nrfconnect/sdk-zephyr@8411e6a nrfconnect/sdk-zephyr@6ccfcdc nrfconnect/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 18, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 8

Inputs:

Sources:

sidewalk: PR head: 34568df6fb89567332e4b628e89233422d07223e
sdk-nrf: PR head: 7a3be91f1c13105d33dc0c61925b6bf5fc7ec42c
zephyr: PR head: 6ccfcdc1051d9d405f694882beb4f306ae518b5c

more details

sidewalk:

PR head: 34568df6fb89567332e4b628e89233422d07223e
merge base: 029f0cff6f5d2aff4697dae76aaab9f96a980c8c
Diff

sdk-nrf:

PR head: 7a3be91f1c13105d33dc0c61925b6bf5fc7ec42c
merge base: ab17c60d832da4cc7d1f41b129473d4a3223f11a
target head (main): ab17c60d832da4cc7d1f41b129473d4a3223f11a
Diff

zephyr:

PR head: 6ccfcdc1051d9d405f694882beb4f306ae518b5c
merge base: 8411e6a346838a2d0980b28e9add8b29a06d711f
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (21)
samples
│  ├── crypto
│  │  ├── persistent_key_usage
│  │  │  ├── boards
│  │  │  │  ├── nrf5340dk_nrf5340_cpuapp_ns.conf
│  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp_ns.conf
│  │  │  │  ├── nrf54l15pdk_nrf54l15_cpuapp.conf
│  │  │  │  ├── nrf9151dk_nrf9151_ns.conf
│  │  │  │  ├── nrf9160dk_nrf9160_ns.conf
│  │  │  │  │ nrf9161dk_nrf9161_ns.conf
│  │  │  │ prj.conf
│  ├── nrf_rpc
│  │  ├── protocols_serialization
│  │  │  ├── server
│  │  │  │  ├── boards
│  │  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  │  │  │ nrf54l15pdk_nrf54l15_cpuapp.conf
sidewalk
│  ├── CMakeLists.txt
│  ├── Kconfig.dependencies
│  ├── samples
│  │  ├── sid_end_device
│  │  │  │ Kconfig.defconfig
│  ├── subsys
│  │  ├── sal
│  │  │  ├── sid_pal
│  │  │  │  ├── src
│  │  │  │  │  │ sid_ble_connection.c
│  ├── tests
│  │  ├── functional
│  │  │  ├── storage
│  │  │  │  │ Kconfig
│  │  ├── unit_tests
│  │  │  ├── pal_storage_kv
│  │  │  │  │ testcase.yaml
│  │  │  ├── sid_ble_connection
│  │  │  │  ├── src
│  │  │  │  │  │ main.c
subsys
│  ├── trusted_storage
│  │  │ Kconfig
west.yml
zephyr
│  ├── include
│  │  ├── zephyr
│  │  │  ├── fs
│  │  │  │  │ zms.h
│  ├── subsys
│  │  ├── fs
│  │  │  ├── zms
│  │  │  │  │ zms.c

Outputs:

Toolchain

Version: 3dd8985b56
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:3dd8985b56_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 663
    • sdk-zephyr test count: 6252
  • ✅ Integration tests
    • ✅ test-sdk-audio
    • ✅ test-fw-nrfconnect-nfc
    • ✅ test-fw-nrfconnect-nrf-iot_thingy91
    • ✅ test-fw-nrfconnect-nrf_crypto
    • ✅ test-fw-nrfconnect-rpc
    • ✅ test-sdk-find-my
    • ✅ test-sdk-sidewalk
    • ✅ test-low-level
    • ✅ test-sdk-dfu
    • ✅ test-fw-nrfconnect-ps
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@tomi-font tomi-font removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 18, 2024
@tomi-font tomi-font mentioned this pull request Oct 18, 2024
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@tomi-font tomi-font force-pushed the security_nrf54l15_trusted_storage_zms branch from 918f03d to 5003df4 Compare October 18, 2024 07:55
@tomi-font tomi-font requested review from a team as code owners October 18, 2024 07:55
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 18, 2024
@tomi-font tomi-font requested review from a team as code owners October 18, 2024 10:43
@tomi-font tomi-font removed the CI-all-test Run All integration tests label Oct 18, 2024
@tomi-font tomi-font force-pushed the security_nrf54l15_trusted_storage_zms branch 2 times, most recently from 4e20593 to 2ba5cf8 Compare October 21, 2024 06:48
@mia-ko mia-ko added this to the 2.8.0 milestone Oct 21, 2024
Copy link
Contributor

@mia-ko mia-ko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related doc PR: #18027

@tomi-font tomi-font added the CI-all-test Run All integration tests label Oct 21, 2024
@tomi-font tomi-font force-pushed the security_nrf54l15_trusted_storage_zms branch from 2ba5cf8 to a32d193 Compare October 21, 2024 08:57
@NordicBuilder NordicBuilder removed the DNM label Oct 21, 2024
@tomi-font tomi-font removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 21, 2024
@rlubos
Copy link
Contributor

rlubos commented Oct 21, 2024

@nrfconnect/ncs-co-build-system @nrfconnect/ncs-aegir @nrfconnect/ncs-modem Please review

@tomi-font tomi-font force-pushed the security_nrf54l15_trusted_storage_zms branch from a32d193 to e90fc4f Compare October 21, 2024 10:27
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 21, 2024
@tomi-font tomi-font removed CI-all-test Run All integration tests changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Oct 21, 2024
And fix the main configuration file by moving
`CONFIG_TFM_ITS_ENCRYPTED=y` to the TF-M board targets' ones.

Signed-off-by: Tomi Fontanilles <[email protected]>
The trusted storage library's storage backend now requires using ZMS
instead of NVS on the nRF54l15.
Make the same additions than in
3ad9997.

Signed-off-by: Tomi Fontanilles <[email protected]>
To fix compilation warnings that in certain scenarios become errors,
and that should just be fixed anyway.

Signed-off-by: Tomi Fontanilles <[email protected]>
Pull in needed changes to align with the switch from NVS to ZMS
for 54L15.

Signed-off-by: Tomi Fontanilles <[email protected]>
Force ZMS to be used as it's way better for RRAM.

Signed-off-by: Tomi Fontanilles <[email protected]>
@tomi-font tomi-font force-pushed the security_nrf54l15_trusted_storage_zms branch from e90fc4f to 7a3be91 Compare October 21, 2024 10:31
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 21, 2024
@tomi-font tomi-font removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 21, 2024
Copy link
Contributor

@eivindj-nordic eivindj-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though, not sure why @nrfconnect/ncs-modem was added to this(?).

@tomi-font
Copy link
Contributor Author

ping @nrfconnect/ncs-aegir

Copy link
Contributor

@frkv frkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rlubos rlubos merged commit 5cfc27d into nrfconnect:main Oct 21, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants