Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub workflows for extra coverage #1223

Merged
merged 2 commits into from
May 14, 2024
Merged

Add GitHub workflows for extra coverage #1223

merged 2 commits into from
May 14, 2024

Commits on May 14, 2024

  1. .mailmap: Add an entry for Ava's GitHub address 

    You can always see the original names/addresses used by passing
--no-mailmap to the various git commands.

See gitmailmap(5)

Reviewed-by: Ava Hahn <[email protected]>
Signed-off-by: Andrew Clayton <[email protected]>
    @ac000
    ac000 committed May 14, 2024
    Configuration menu
    Copy the full SHA
    44709be View commit details
    Browse the repository at this point in the history

  2. Add GitHub workflows for extra coverage 

    This adds a workflow for building Unit under Fedora Rawhide and Alpine
Edge with both GCC and Clang.

These are the development branches from which releases are cut.

This usually consists of the latest versions of software and will
hopefully catch new compiler issues and API breakages in the various
languages we support.

With Alpine and Clang that also gives us musl libc + clang coverage.

On Alpine we don't build the wasm and wasm-wasi-component modules,
mainly as this would require messing around with all the rust stuff and
building wasmtime from source (as there's no musl libc based packages)
and the wasm module is pretty small, any new compiler issues would
hopefully show up in the rest.

We _do_ build the wasm module with gcc and clang on Fedora. But not
wasm-wasi-component in the interests of time. Can be added at a later
date if deemed necessary.

We don't build the Perl language module on Fedora with clang due to the
Fedora (and probably Red Hat) Perl CFLAGS having incompatible with clang
flags.

We probably could work around it if we really wanted to, but not sure
it's worth it and on Red Hat/Fedora, GCC _is_ the system compiler.

On Alpine we also don't build the nodejs and go language modules as
there's nothing that actually gets compiled there and the _main_ reason
for building on Alpine is to get musl libc + clang coverage.

We're also not bothering with njs for now... can be revisited at a
later date.

Also no pytests, these should be well covered via other workflows for
example by running on latest Alpine releases.

Closes: nginx#949
Signed-off-by: Andrew Clayton <[email protected]>
    @ac000
    ac000 committed May 14, 2024
    Configuration menu
    Copy the full SHA
    30b39bd View commit details
    Browse the repository at this point in the history