Add GitHub workflows for extra coverage #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ac000
force-pushed
the
workflows
branch
30 times, most recently
from
31a94ff
to
4b1838a
Compare
ac000
changed the title
|
These new checks finish in under half the time of the existing CI, so shouldn't have an adverse effect on the testing time... |
|
Added a |
|
Update to wasmtime 20.0.0 |
ac000
commented
Apr 25, 2024
|
ac000
changed the title
|
Split the white space check into its own PR. |
|
|
Ok, this is now ready for merging. To recap. This is building Unit under Fedora Rawhide and Alpine Edge with both GCC and Clang. This is mainly to get coverage with the latest toolchain developments but also for upcoming versions of the various language stuff. This already found a build issue with the Perl language module and Clang. So, last chance to speak up or forever hold yer whisht! ;) |
You can always see the original names/addresses used by passing --no-mailmap to the various git commands. See gitmailmap(5) Reviewed-by: Ava Hahn <[email protected]> Signed-off-by: Andrew Clayton <[email protected]>
|
Rebased with master |
This adds a workflow for building Unit under Fedora Rawhide and Alpine Edge with both GCC and Clang. These are the development branches from which releases are cut. This usually consists of the latest versions of software and will hopefully catch new compiler issues and API breakages in the various languages we support. With Alpine and Clang that also gives us musl libc + clang coverage. On Alpine we don't build the wasm and wasm-wasi-component modules, mainly as this would require messing around with all the rust stuff and building wasmtime from source (as there's no musl libc based packages) and the wasm module is pretty small, any new compiler issues would hopefully show up in the rest. We _do_ build the wasm module with gcc and clang on Fedora. But not wasm-wasi-component in the interests of time. Can be added at a later date if deemed necessary. We don't build the Perl language module on Fedora with clang due to the Fedora (and probably Red Hat) Perl CFLAGS having incompatible with clang flags. We probably could work around it if we really wanted to, but not sure it's worth it and on Red Hat/Fedora, GCC _is_ the system compiler. On Alpine we also don't build the nodejs and go language modules as there's nothing that actually gets compiled there and the _main_ reason for building on Alpine is to get musl libc + clang coverage. We're also not bothering with njs for now... can be revisited at a later date. Also no pytests, these should be well covered via other workflows for example by running on latest Alpine releases. Closes: nginx#949 Signed-off-by: Andrew Clayton <[email protected]>
|
Rebased with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a workflow for building Unit under Fedora Rawhide and Alpine
Edge with both GCC and Clang.
These are the development branches from which releases are cut.
This usually consists of the latest versions of software and will
hopefully catch new compiler issues and API breakages in the various
languages we support.
With Alpine and Clang that also gives us musl libc + clang coverage.
On Alpine we don't build the wasm and wasm-wasi-component modules,
mainly as this would require messing around with all the rust stuff and
building wasmtime from source (as there's no musl libc based packages)
and the wasm module is pretty small, any new compiler issues would
hopefully show up in the rest.
We do build the wasm module with gcc and clang on Fedora. But not
wasm-wasi-component in the interests of time. Can be added at a later
date if deemed necessary.
We don't build the Perl language module on Fedora with clang due to the
Fedora (and probably Red Hat) Perl CFLAGS having incompatible with clang
flags.
We probably could work around it if we really wanted to, but not sure
it's worth it and on Red Hat/Fedora, GCC is the system compiler.
On Alpine we also don't build the nodejs and go language modules as
there's nothing that actually gets compiled there and the main reason
for building on Alpine is to get musl libc + clang coverage.
We're also not bothering with njs for now... can be revisited at a
later date.
Also no pytests, these should be well covered via other workflows for
example by running on latest Alpine releases.