if probe url includes a https we set the appropriate header, that mag…

[whizkid79]

…ento doesn't replies with a redirect but the correct status code.

[miguelbalparda]

How will this impact users not using https? Do you foresee any backward compatibility issue?

[whizkid79]

it only triggers when the probe url includes https as protocol, see additional lines below. if this is not the case, the variable will be empty and therefore it will produce the same result like before.

[miguelbalparda]

So you mean having Host: {{probe_host}} with a value for {{probe_host}} will be the same as having Host: {{probe_host}} where {{probe_host}} will be rendered into an empty string? I'd like to have a cleaner approach to take both http an https into account and not return an empty string instead of the host returned by parse_url.

[whizkid79]

i didn't change anything on {{probe_host}}. this contains only the host part of the url, e.g. www.website.com. For clarification, i add two sample results, one with and one without https configured for the probe:

Probe url set to http://www.website.com/test.php results in:

            .probe = {
                .request =
                    "GET /test.php HTTP/1.1"
                    "Host: www.website.com"
                    "Connection: close";
            }

Probe url set to https://www.website.com/test.php results in:

            .probe = {
                .request =
                    "GET /test.php HTTP/1.1"
                    "Host: www.website.com"
                    "X-Forwarded-Proto: https"
                    "Connection: close";
            }

[miguelbalparda]

My bad, I misinterpreted the preview of the files changed. I thought you deleted {{probe_host}} in favor of {{probe_https}} but that wasn't the case.

[whizkid79]

not sure where, but this would be good to be written down somewhere in the docs if it gets merged.

[whizkid79]

@miguelbalparda is this PR likely to be merged? If not, I need to overwrite this for my current project.

[miguelbalparda]

I didn't test this in detail, if it gets merged it will be first in the devel branch and then moved to a stable version after some time, allowing others to test it first.