Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: reexport cargo-near-build for configurable build if needed #386

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

dj8yfo
Copy link
Contributor

@dj8yfo dj8yfo commented Nov 13, 2024

PR addresses this TODO near/near-sdk-rs#1253 (comment) , which later will be has been removed from near-sdk code, for cases:

  1. when non-async function is required in static std::sync::OnceLock<T>/LazyLock<T, F> creation like here https://github.com/dj8yfo/near-sdk-rs/blob/7be211e1b2991f6c5b4db78972784dac2f066e32/examples/fungible-token/tests/workspaces.rs#L47
  2. when non-default build is required like with no-abi here https://github.com/dj8yfo/abstract-dao/blob/fe9d16797bf582f0ea24380c1e4ad6bdb8c97283/tests/common.rs#L33

PR avoids necessity to import cargo-near-build separately as a dependency

PR should best be published with a major release, to avoid weird breakage 0.14.1 -> 0.14.x

@dj8yfo
Copy link
Contributor Author

dj8yfo commented Nov 13, 2024

@race-of-sloths include

@race-of-sloths
Copy link

race-of-sloths commented Nov 13, 2024

@dj8yfo Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Weekly streak is on the road, smart strategy! Secure your streak with another PR!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@akorchyn 3

Your contribution is much appreciated with a final score of 3!
You have received 66 (30 base + 30 weekly bonus + 10% lifetime bonus) Sloth points for this contribution

@akorchyn received 25 Sloth Points for reviewing and scoring this pull request.

Another weekly streak completed, well done @dj8yfo! To keep your weekly streak and get another bonus make pull request next week! Looking forward to see you in race-of-sloths

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths and receive a reward
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@dj8yfo dj8yfo marked this pull request as ready for review November 13, 2024 14:39
@akorchyn akorchyn changed the title chore: reexport cargo-near-build for configurable build if needed chore!: reexport cargo-near-build for configurable build if needed Nov 15, 2024
Copy link
Collaborator

@akorchyn akorchyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@race-of-sloths score 3

@akorchyn akorchyn merged commit df6230c into near:main Nov 15, 2024
6 checks passed
@frol frol mentioned this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants