ci: compile `test_examples{,_small}.yml` with `near_workspaces::compile_project` #1253

dj8yfo · 2024-11-05T20:53:08Z

No description provided.

codecov · 2024-11-05T21:12:27Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.30%. Comparing base (7a8dd79) to head (c6c9512).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1253      +/-   ##
==========================================
+ Coverage   80.14%   80.30%   +0.16%     
==========================================
  Files         102      102              
  Lines       14598    14598              
==========================================
+ Hits        11699    11723      +24     
+ Misses       2899     2875      -24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dj8yfo · 2024-11-06T11:51:48Z

fail-fast was disabled for matrices to see full information of what's failing in ci to avoid having to do more sequential run-ci/change-code cycles

dj8yfo · 2024-11-06T12:17:02Z

@race-of-sloths include

race-of-sloths · 2024-11-06T12:19:22Z

@dj8yfo Thank you for your contribution! Your pull request is now a part of the Race of Sloths!

Current status: waiting for finalization

The pull request is merged, you have 24 hours to finalize your scoring. The scoring ends Tue Nov 19 14:44:37 2024

Reviewer	Score
@frol	8

Your contribution is much appreciated with a final score of 8!
You have received 80 Sloth points for this contribution

@frol received 25 Sloth Points for reviewing and scoring this pull request.

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

Tag @race-of-sloths inside your pull requests
Wait for the maintainer to review and score your pull request
Check out your position in the Leaderboard
Keep weekly and monthly streaks to reach higher positions
Boast your contributions with a dynamic picture of your Profile

For maintainers:

Score pull requests that participate in the Race of Sloths and receive a reward
Engage contributors with fair scoring and fast responses so they keep their streaks
Promote the Race to the point where the Race starts promoting you
Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands

For contributors
- Include a PR: @race-of-sloths include to enter the Race with your PR
For maintainers:
- Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
- Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
- Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
- Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

.github/workflows/test_examples_small.yml

frol

@dj8yfo Overall, it looks great, but how much did it affect CI times?

examples/adder/src/lib.rs

frol · 2024-11-08T02:47:50Z

examples/non-fungible-token/tests/workspaces/test_approval.rs

+#[rstest]
 #[tokio::test]
-async fn simulate_simple_approve() -> anyhow::Result<()> {
-    let worker = near_workspaces::sandbox().await?;
-    let (nft_contract, alice, token_receiver_contract, _) = init(&worker).await?;
+async fn simulate_simple_approve(
+    #[future] initialized_contracts: anyhow::Result<(Contract, Account, Contract, Contract)>,
+) -> anyhow::Result<()> {
+    let (nft_contract, alice, token_receiver_contract, _) = initialized_contracts.await?;


Do we win much from using fixtures here? It took me several minutes to figure out and I think it is unnecessary magical, and makes the code less readable. Also, rstest dependency might add extra compilation time.

such a minimal manifest with rstest with a corresponding test

[package] name = "rstest_play" version = "0.1.0" edition = "2021" [dependencies] [dev-dependencies] rstest = "0.23.0"

compiles for

Compiling rstest v0.23.0 Finished `test` profile [unoptimized + debuginfo] target(s) in 4.86s

on my machine, which would probably mean 10-15 secs on gh executor

examples/fungible-token/tests/workspaces.rs

dj8yfo · 2024-11-11T19:27:48Z

referencing nearuaguild/abstract-dao#9 , as full picture will be important anyway.

Likely the contract therein has been fixed by changes introduces, because the state of the base branch of pr
reacted with status: Failure(ActionError(ActionError { index: Some(0), kind: FunctionCallError(CompilationError(PrepareError(Deserialization))) })) in its only test test_sign_eip1559_payload_on_many_chains , that uses near_workspaces::sandbox, if run on 1.82.

Whereas the test passes in the compare branch of pr on 1.82

…386) PR addresses this TODO near/near-sdk-rs#1253 (comment) , which later ~will be~ has been removed from `near-sdk` code, for cases: 1. when non-async function is required in `static std::sync::OnceLock<T>/LazyLock<T, F>` creation like here https://github.com/dj8yfo/near-sdk-rs/blob/7be211e1b2991f6c5b4db78972784dac2f066e32/examples/fungible-token/tests/workspaces.rs#L47 2. when non-default build is required like with `no-abi` here https://github.com/dj8yfo/abstract-dao/blob/fe9d16797bf582f0ea24380c1e4ad6bdb8c97283/tests/common.rs#L33 PR avoids necessity to import `cargo-near-build` separately as a dependency PR should best be published with a major release, to avoid weird breakage `0.14.1 -> 0.14.x` Co-authored-by: dj8yf0μl <[email protected]>

frol

@race-of-sloths score 8

dj8yf0μl added 8 commits October 30, 2024 20:44

test: adder example

fa0f537

test: callback-results example

cf87432

test: cross-contract-calls example

1d306da

test: fungible-token example

b60f83c

test: non-fungible-token example

74440fb

test: versioned example

31b65a4

test: factory-contract example

91c2e88

ci: typo

f24a608

dj8yf0μl and others added 3 commits November 5, 2024 23:40

fix: add .no_locked(true) to build scripts config (status-message dep)

411fd20

Merge branch 'master' into near_workspaces_compile_project

9a98143

test: add near_workspaces test for versioned contract

9ff59d9

dj8yfo marked this pull request as ready for review November 6, 2024 12:16

dj8yfo requested review from frol, ruseinov and akorchyn as code owners November 6, 2024 12:16

dj8yf0μl added 7 commits November 6, 2024 23:58

chore: common build_contract fn in fungible-token

48f244e

test: lockable-fungible-token example (small)

c6f8673

test: status-message example (small)

ef7a22a

test: mission-control example (small)

86f740a

test: test-contract example (small)

9c04d4c

ci: typo

8dbfab5

ci: replace small examples with matrix

7be211e

dj8yfo force-pushed the near_workspaces_compile_project branch from f806125 to 7be211e Compare November 7, 2024 18:06

dj8yfo commented Nov 7, 2024

View reviewed changes

.github/workflows/test_examples_small.yml Show resolved Hide resolved

dj8yfo commented Nov 7, 2024

View reviewed changes

.github/workflows/test_examples_small.yml Show resolved Hide resolved

dj8yfo changed the title ~~ci: compile test-examples.yml with near_workspaces::compile_project~~ ci: compile test_examples{,_small}.yml with near_workspaces::compile_project Nov 7, 2024

frol reviewed Nov 8, 2024

View reviewed changes

This was referenced Nov 13, 2024

chore!: reexport cargo-near-build for configurable build if needed near/near-workspaces-rs#386

Merged

chore: updates near-* dependencies to 0.27 release #1254

Merged

todo: remove introduced todos

b4b3dff

This was referenced Nov 13, 2024

Add near-workspaces tests to test/demo some of the examples #1256

Open

remove direct dependency on cargo-near-build in some of examples #1257

Open

Merge branch 'master' into near_workspaces_compile_project

0fc7eb9

Merge branch 'master' into near_workspaces_compile_project

c6c9512

frol approved these changes Nov 18, 2024

View reviewed changes

frol merged commit 80723b9 into near:master Nov 18, 2024
38 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: compile `test_examples{,_small}.yml` with `near_workspaces::compile_project` #1253

ci: compile `test_examples{,_small}.yml` with `near_workspaces::compile_project` #1253

dj8yfo commented Nov 5, 2024 •

edited

Loading

codecov bot commented Nov 5, 2024 •

edited

Loading

dj8yfo commented Nov 6, 2024

dj8yfo commented Nov 6, 2024

race-of-sloths commented Nov 6, 2024 •

edited

Loading

frol left a comment

frol Nov 8, 2024

dj8yfo Nov 13, 2024

dj8yfo commented Nov 11, 2024 •

edited

Loading

frol left a comment

ci: compile test_examples{,_small}.yml with near_workspaces::compile_project #1253

ci: compile test_examples{,_small}.yml with near_workspaces::compile_project #1253

Conversation

dj8yfo commented Nov 5, 2024 • edited Loading

codecov bot commented Nov 5, 2024 • edited Loading

Codecov Report

dj8yfo commented Nov 6, 2024

dj8yfo commented Nov 6, 2024

race-of-sloths commented Nov 6, 2024 • edited Loading

frol left a comment

Choose a reason for hiding this comment

frol Nov 8, 2024

Choose a reason for hiding this comment

dj8yfo Nov 13, 2024

Choose a reason for hiding this comment

dj8yfo commented Nov 11, 2024 • edited Loading

frol left a comment

Choose a reason for hiding this comment

ci: compile `test_examples{,_small}.yml` with `near_workspaces::compile_project` #1253

ci: compile `test_examples{,_small}.yml` with `near_workspaces::compile_project` #1253

dj8yfo commented Nov 5, 2024 •

edited

Loading

codecov bot commented Nov 5, 2024 •

edited

Loading

race-of-sloths commented Nov 6, 2024 •

edited

Loading

dj8yfo commented Nov 11, 2024 •

edited

Loading