Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes and improvements to new alerts front end #1846

Draft
wants to merge 17 commits into
base: alert-front-end-vector-suggestions
Choose a base branch
from
Draft

Small fixes and improvements to new alerts front end #1846

wants to merge 17 commits into from

Commits on Oct 31, 2024

  1. make new alert searches use OR for keywords 

    Join multiple keywords with OR so any matches rather than having to
match on all.
    @struan
    struan committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    1c0311e View commit details
    Browse the repository at this point in the history

  2. optionally enable matching all terms in an alert 

    Add checkbox to match all terms rather than any term as is the default
    @struan
    struan committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    9e728ec View commit details
    Browse the repository at this point in the history

  3. group MP alerts together on alert page 

    Also fix listing your own MP's alerts
    @struan
    struan committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    70b1bbb View commit details
    Browse the repository at this point in the history

  4. do not display disambigation options after editing an alert 

    If the alert had a person in it then we weren't unsetting members or
constituencies so it was still showing disambigution options after
editing. Unset these to prevent that.
    @struan
    struan committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    fe96373 View commit details
    Browse the repository at this point in the history

  5. only use alertsearch on alert page for queries from elsewhere 

    Makes it easier to decide what to do when we get to the alert page and
to know when we're handing a form or a link from elswhere
    @struan
    struan committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    80d7624 View commit details
    Browse the repository at this point in the history

  6. display your own MP's keywords alerts even if no speaks alert 

    Even if you haven't signed up for a "everything they say" alert from
your MP show any "when they mention" alerts under the speaks sign up
prompt. Splits the alert list into a separate template to make this
easier.
    @struan
    struan committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    84f35cb View commit details
    Browse the repository at this point in the history

  7. add in some more alert page tests

    @struan
    struan committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    e27eb1b View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Tidy up front-end

    @lucascumsille
    lucascumsille committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    251f82c View commit details
    Browse the repository at this point in the history

  2. Remove discard changes buttton

    @lucascumsille
    lucascumsille committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    e83ea9d View commit details
    Browse the repository at this point in the history

  3. fixup! Tidy up front-end

    @lucascumsille
    lucascumsille committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    6020246 View commit details
    Browse the repository at this point in the history

  4. Added minor improvements to buttons

    @lucascumsille
    lucascumsille committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    99b8cb0 View commit details
    Browse the repository at this point in the history

  5. fixup! Tidy up front-end

    @lucascumsille
    lucascumsille committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    9d0db9d View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. add some diagnostics to the vector search import script

    @struan
    struan committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    d5e75e5 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. spelling fix

    @struan
    struan committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    f017fcb View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. fixup! Tidy up front-end

    @lucascumsille
    lucascumsille committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    ec3a379 View commit details
    Browse the repository at this point in the history

  2. Added frontend to MP section

    @lucascumsille
    lucascumsille committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    954522e View commit details
    Browse the repository at this point in the history

  3. fixup! Tidy up front-end

    @lucascumsille
    lucascumsille committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    2d70cf1 View commit details
    Browse the repository at this point in the history