-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small fixes and improvements to new alerts front end #1846
base: alert-front-end-vector-suggestions
Are you sure you want to change the base?
Small fixes and improvements to new alerts front end #1846
Conversation
Join multiple keywords with OR so any matches rather than having to match on all.
Add checkbox to match all terms rather than any term as is the default
Also fix listing your own MP's alerts
If the alert had a person in it then we weren't unsetting members or constituencies so it was still showing disambigution options after editing. Unset these to prevent that.
Makes it easier to decide what to do when we get to the alert page and to know when we're handing a form or a link from elswhere
Even if you haven't signed up for a "everything they say" alert from your MP show any "when they mention" alerts under the speaks sign up prompt. Splits the alert list into a separate template to make this easier.
@ajparsons and @struan not sure if I'll be able to finish this before going on holiday so I'll leave a few notes for when I'm back and I can have a catch up with Struan: Just in case I'll keep updating this comment during the day. Don't need to reply to this comment now, happy to have a catch up when I'm back. Alert page
Create Alert: Keywords
Create Alert : MPs
<?php if ($pid || $keyword) { ?>
<button type="submit" class="button" name="mp_step" value="mp_confirm">
<span><?= gettext('Subscribe') ?></span>
<i aria-hidden="true" class="fi-megaphone"></i>
</button>
<?php } else { ?>
|
This is a roll up commit with some small changes (include all or any of keywords) plus fixes to linking from elsewhere in TWFY to the search page.
Part of #1824