Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes and improvements to new alerts front end #1846

Draft
wants to merge 17 commits into
base: alert-front-end-vector-suggestions
Choose a base branch
from

Conversation

struan
Copy link
Member

@struan struan commented Oct 31, 2024

This is a roll up commit with some small changes (include all or any of keywords) plus fixes to linking from elsewhere in TWFY to the search page.

Part of #1824

Join multiple keywords with OR so any matches rather than having to
match on all.
Add checkbox to match all terms rather than any term as is the default
Also fix listing your own MP's alerts
If the alert had a person in it then we weren't unsetting members or
constituencies so it was still showing disambigution options after
editing. Unset these to prevent that.
Makes it easier to decide what to do when we get to the alert page and
to know when we're handing a form or a link from elswhere
Even if you haven't signed up for a "everything they say" alert from
your MP show any "when they mention" alerts under the speaks sign up
prompt. Splits the alert list into a separate template to make this
easier.
@struan struan changed the title Alert front end small fixes Small fixes and improvements to new alerts front end Oct 31, 2024
@lucascumsille
Copy link
Contributor

lucascumsille commented Nov 18, 2024

@ajparsons and @struan not sure if I'll be able to finish this before going on holiday so I'll leave a few notes for when I'm back and I can have a catch up with Struan:

Just in case I'll keep updating this comment during the day.

Don't need to reply to this comment now, happy to have a catch up when I'm back.

Alert page

  • Is it possible to move the "MP is mentioned" from the keywords section. If it's too much hassle I should add a message in the MP section telling users the MP mention is in the key word section.
  • Change secondary buttons inside the accordions and MP sections to outline ones, so the page is not so saturated with colours
  • Move icons from right side to left to provide better context to users.
  • "Abandon changes" button has a green border

Create Alert: Keywords

  • I want to check with Struan if I'm missing something in the journey, but so far so good.
  • I'll "Search tips" currently on /alerts on this create alert page, it will be more useful when creating an alert
  • When in related terms section, it would be nice that when we press the "all" option it adds a check mark to all of them, but if removed then it should keep the original terms checked,

Create Alert : MPs

  • I'm a bit confused when I add a postcode and then press search, I'm not actually searching, is instantly creating the alert. Is this the behaviour we expect? if so I'll probably change the name
Screenshot 2024-11-18 at 10 14 28
  • Double checking but currently if I add a postcode I create an alert for my MP,

  • Related to the previous point I can see there is a 'Subscribe' button but is wrapped on a conditional. I couldn't understand the logic behind it though

        <?php if ($pid || $keyword) { ?>
        <button type="submit" class="button" name="mp_step" value="mp_confirm">
          <span><?= gettext('Subscribe') ?></span>
          <i aria-hidden="true" class="fi-megaphone"></i>
        </button>
        <?php } else { ?>
  • Double checking, but am I right to think the create alert only has one step at the moment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants