Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Surrey] Add text under happy-or-not section #5256

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −0
Open

[Surrey] Add text under happy-or-not section #5256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions templates/web/surrey/footer_extra.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
<section id="happy-or-not-smiley-section">
<div id="happy-or-not-smiley-digital-embed"></div>
<div class="container" id="happy-or-not-feedback-statement">
<p>We’d love you to give us some feedback on how easy it was to report this issue. Please note this feedback will not be included as part of your report.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splitting this in the middle improves the display a bit...

Suggested change
<p>We’d love you to give us some feedback on how easy it was to report this issue. Please note this feedback will not be included as part of your report.</p>
<p>We’d love you to give us some feedback on how easy it was to report this issue.</p>
<p>Please note this feedback will not be included as part of your report.</p>

</div>
</section>

<section class="scc-subscribe">
Expand Down
4 changes: 4 additions & 0 deletions web/cobrands/surrey/base.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,10 @@ a#geolocate_link,
background: #f3f6f9;
}

#happy-or-not-feedback-statement {
padding: 1em 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...and then maybe centre the text too:

Suggested change
padding: 1em 0;
padding: 1em 0;
text-align: center;

}

.scc-subscribe {
background-color: #e0e7cf;
padding: 0.9375rem 0;
Expand Down
Loading