[Surrey] Add text under happy-or-not section #5256
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5256 +/- ##
=======================================
Coverage 82.39% 82.39%
=======================================
Files 409 409
Lines 32093 32093
Branches 5121 5121
=======================================
Hits 26443 26443
Misses 4130 4130
Partials 1520 1520 ☔ View full report in Codecov by Sentry. |
davea
requested changes
Nov 14, 2024
There was a problem hiding this comment.
Looking good, a couple of small things to improve display, but primarily I don't think this makes sense on every page where the HoN widget appears. The front page, for example, where the user hasn't made a report yet.
Is there a way to only include/display this text on the problem confirmation page?
| @@ -1,5 +1,8 @@ | |||
| <section id="happy-or-not-smiley-section"> | |||
| <div id="happy-or-not-smiley-digital-embed"></div> | |||
| <div class="container" id="happy-or-not-feedback-statement"> | |||
| <p>We’d love you to give us some feedback on how easy it was to report this issue. Please note this feedback will not be included as part of your report.</p> | |||
There was a problem hiding this comment.
Splitting this in the middle improves the display a bit...
Suggested change
| <p>We’d love you to give us some feedback on how easy it was to report this issue. Please note this feedback will not be included as part of your report.</p> | |
| <p>We’d love you to give us some feedback on how easy it was to report this issue.</p> | |
| <p>Please note this feedback will not be included as part of your report.</p> |
| @@ -184,6 +184,10 @@ a#geolocate_link, | |||
| background: #f3f6f9; | |||
| } | |||
|
|
|||
| #happy-or-not-feedback-statement { | |||
| padding: 1em 0; | |||
There was a problem hiding this comment.
...and then maybe centre the text too:
Suggested change
| padding: 1em 0; | |
| padding: 1em 0; | |
| text-align: center; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For FD-4776