Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to go1.18, drop go1.18, and replace deprecated syscall.Syscall<number> #283

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

update to go1.18, drop go1.18, and replace deprecated syscall.Syscall<number> #283

wants to merge 5 commits into from

Commits on Apr 8, 2023

  1. lzx: decompressor.readCompressedBlock: simplify break statement (revive) 

        wim/lzx/lzx.go:492:3: early-return: if c { ... } else { ... break } can be simplified to if !c { ... break } ... (revive)
            if matchoffset <= i && matchlen <= end-i {
                copyend := i + matchlen
                for ; i < copyend; i++ {
                    f.window[i] = f.window[i-matchoffset]
                }
            } else {
                f.fail(errCorrupt)
                break
            }

Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @thaJeztah
    thaJeztah committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    42f9d75 View commit details
    Browse the repository at this point in the history

  2. gha: update golangci-lint to v1.52.x 

    pkg/security:

    Error: directive `//nolint:structcheck,unused // structcheck thinks fields are unused, but the are used to pass data to OS` is unused for linter "unused" (nolintlint)

Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @thaJeztah
    thaJeztah committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    d42e9a3 View commit details
    Browse the repository at this point in the history

  3. update to go1.18, and fix linting issues 

    pkg/etw, pkg/etwlogrus: replace interface{} with any (revive)

    Warning: use-any: since GO 1.18 'interface{}' can be replaced by 'any' (revive)
    Warning: use-any: since GO 1.18 'interface{}' can be replaced by 'any' (revive)

Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @thaJeztah
    thaJeztah committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    8e9b812 View commit details
    Browse the repository at this point in the history

  4. tools/mkwinsyscall: replace deprecated funcs with SyscallN (drops go1… 

    ….17)

The "syscall.Syscall<number>" functions were deprecated in go1.18 in favor
of the "syscall.SyscallN" function, which does not need the "nargs" argument,
and does not need the list of arguments to be padded with zeros.
https://github.com/golang/go/blob/go1.18/src/syscall/dll_windows.go#L27-L45

Now that go1.17 reached EOL and is no longer maintained, we can update the
code to use the new SyscallN function. This patch updates the mkwinsyscall
utility to generate code using the new SyscallN function, and removes the
utilities that are now redundant.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @thaJeztah
    thaJeztah committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    7249942 View commit details
    Browse the repository at this point in the history

  5. internal/socket: replace deprecated syscall.Syscall9 

    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @thaJeztah
    thaJeztah committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    d88b00b View commit details
    Browse the repository at this point in the history