update to go1.18, drop go1.18, and replace deprecated syscall.Syscall<number> #283
Conversation
| r1, _, e1 := syscall.Syscall(procbind.Addr(), 3, uintptr(s), uintptr(name), uintptr(namelen)) | ||
| r1, _, e1 := syscall.SyscallN(procbind.Addr(), uintptr(s), uintptr(name), uintptr(namelen)) |
There was a problem hiding this comment.
go generate unless doing so on a Windows machine).
Not 100% sure if CI here verifies these files (if not, perhaps someone could double-check them and run go generate on a Windows machine)
There was a problem hiding this comment.
Not 100% sure if CI here verifies these files (if not, perhaps someone could double-check them and run
go generateon a Windows machine)
looks like it does, and CI looks happy; https://github.com/thaJeztah/go-winio/actions/runs/4645965648
thaJeztah
force-pushed
the
remove_deprecated_syscall
branch
6 times, most recently
from
1d52ae4
to
7f78199
Compare
wim/lzx/lzx.go:492:3: early-return: if c { ... } else { ... break } can be simplified to if !c { ... break } ... (revive)
if matchoffset <= i && matchlen <= end-i {
copyend := i + matchlen
for ; i < copyend; i++ {
f.window[i] = f.window[i-matchoffset]
}
} else {
f.fail(errCorrupt)
break
}
Signed-off-by: Sebastiaan van Stijn <[email protected]>
pkg/security:
Error: directive `//nolint:structcheck,unused // structcheck thinks fields are unused, but the are used to pass data to OS` is unused for linter "unused" (nolintlint)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
pkg/etw, pkg/etwlogrus: replace interface{} with any (revive)
Warning: use-any: since GO 1.18 'interface{}' can be replaced by 'any' (revive)
Warning: use-any: since GO 1.18 'interface{}' can be replaced by 'any' (revive)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
….17) The "syscall.Syscall<number>" functions were deprecated in go1.18 in favor of the "syscall.SyscallN" function, which does not need the "nargs" argument, and does not need the list of arguments to be padded with zeros. https://github.com/golang/go/blob/go1.18/src/syscall/dll_windows.go#L27-L45 Now that go1.17 reached EOL and is no longer maintained, we can update the code to use the new SyscallN function. This patch updates the mkwinsyscall utility to generate code using the new SyscallN function, and removes the utilities that are now redundant. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
remove_deprecated_syscall
branch
from
7f78199
to
d88b00b
Compare
|
This should be ready for review /cc @kevpar 😄 (I should probably point out that containerd 1.6 still tests against go1.17 as "old version", in case this version from main ends up in containerd at some point; https://github.com/containerd/containerd/blob/v1.6.20/.github/workflows/ci.yml#L236) |
gha: update golangci-lint to v1.52.x
update to go1.18
tools/mkwinsyscall: replace deprecated funcs with SyscallN (drops go1.17)
The "syscall.Syscall" functions were deprecated in go1.18 in favor
of the "syscall.SyscallN" function, which does not need the "nargs" argument,
and does not need the list of arguments to be padded with zeros.
https://github.com/golang/go/blob/go1.18/src/syscall/dll_windows.go#L27-L45
Now that go1.17 reached EOL and is no longer maintained, we can update the
code to use the new SyscallN function. This patch updates the mkwinsyscall
utility to generate code using the new SyscallN function, and removes the
utilities that are now redundant.
internal/socket: replace deprecated syscall.Syscall9