fix(meshtimeout): don't set default timeouts on inbound cluster and listener #12043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
lukidzi
requested review from
michaelbeaumont and
Icarus9913
and removed request for
a team
michaelbeaumont
approved these changes
Nov 14, 2024
kumahq bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
…istener (#12043) We noticed that when a user upgrades to version 2.9.x without a default MeshTimeout/Timeout policy, default timeouts are applied on inbound clusters and listeners. This could disrupt the existing behavior of the environment. When no policy is present, we simply skip configuration and do not set up the timeouts for inbound cluster or listener. Fix #12033 <!-- > Changelog: skip --> <!-- Uncomment the above section to explicitly set a [`> Changelog:` entry here](https://github.com/kumahq/kuma/blob/master/CONTRIBUTING.md#submitting-a-patch)? --> --------- Signed-off-by: Lukasz Dziedziak <[email protected]>
kumahq bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
…istener (#12043) We noticed that when a user upgrades to version 2.9.x without a default MeshTimeout/Timeout policy, default timeouts are applied on inbound clusters and listeners. This could disrupt the existing behavior of the environment. When no policy is present, we simply skip configuration and do not set up the timeouts for inbound cluster or listener. Fix #12033 <!-- > Changelog: skip --> <!-- Uncomment the above section to explicitly set a [`> Changelog:` entry here](https://github.com/kumahq/kuma/blob/master/CONTRIBUTING.md#submitting-a-patch)? --> --------- Signed-off-by: Lukasz Dziedziak <[email protected]>
kumahq bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
…istener (#12043) ## Motivation We noticed that when a user upgrades to version 2.9.x without a default MeshTimeout/Timeout policy, default timeouts are applied on inbound clusters and listeners. This could disrupt the existing behavior of the environment. ## Implementation information When no policy is present, we simply skip configuration and do not set up the timeouts for inbound cluster or listener. ## Supporting documentation Fix #12033 <!-- > Changelog: skip --> <!-- Uncomment the above section to explicitly set a [`> Changelog:` entry here](https://github.com/kumahq/kuma/blob/master/CONTRIBUTING.md#submitting-a-patch)? --> --------- Signed-off-by: Lukasz Dziedziak <[email protected]>
kumahq bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
…istener (#12043) We noticed that when a user upgrades to version 2.9.x without a default MeshTimeout/Timeout policy, default timeouts are applied on inbound clusters and listeners. This could disrupt the existing behavior of the environment. When no policy is present, we simply skip configuration and do not set up the timeouts for inbound cluster or listener. Fix #12033 <!-- > Changelog: skip --> <!-- Uncomment the above section to explicitly set a [`> Changelog:` entry here](https://github.com/kumahq/kuma/blob/master/CONTRIBUTING.md#submitting-a-patch)? --> --------- Signed-off-by: Lukasz Dziedziak <[email protected]>
kumahq bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
…istener (#12043) We noticed that when a user upgrades to version 2.9.x without a default MeshTimeout/Timeout policy, default timeouts are applied on inbound clusters and listeners. This could disrupt the existing behavior of the environment. When no policy is present, we simply skip configuration and do not set up the timeouts for inbound cluster or listener. Fix #12033 <!-- > Changelog: skip --> <!-- Uncomment the above section to explicitly set a [`> Changelog:` entry here](https://github.com/kumahq/kuma/blob/master/CONTRIBUTING.md#submitting-a-patch)? --> --------- Signed-off-by: Lukasz Dziedziak <[email protected]>
This was referenced Nov 14, 2024
lukidzi
added a commit
that referenced
this pull request
Nov 14, 2024
…istener (backport of #12043) (#12049) Automatic cherry-pick of #12043 for branch release-2.9 Generated by [action](https://github.com/kumahq/kuma/actions/runs/11841875084) cherry-picked commit 844c988 Signed-off-by: Lukasz Dziedziak <[email protected]> Co-authored-by: Lukasz Dziedziak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We noticed that when a user upgrades to version 2.9.x without a default MeshTimeout/Timeout policy, default timeouts are applied on inbound clusters and listeners. This could disrupt the existing behavior of the environment.
Implementation information
When no policy is present, we simply skip configuration and do not set up the timeouts for inbound cluster or listener.
Supporting documentation
Fix #12033