-
Notifications
You must be signed in to change notification settings - Fork 333
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(meshtimeout): don't set default timeouts on inbound cluster and l…
…istener (#12043) ## Motivation We noticed that when a user upgrades to version 2.9.x without a default MeshTimeout/Timeout policy, default timeouts are applied on inbound clusters and listeners. This could disrupt the existing behavior of the environment. ## Implementation information When no policy is present, we simply skip configuration and do not set up the timeouts for inbound cluster or listener. ## Supporting documentation Fix #12033 <!-- > Changelog: skip --> <!-- Uncomment the above section to explicitly set a [`> Changelog:` entry here](https://github.com/kumahq/kuma/blob/master/CONTRIBUTING.md#submitting-a-patch)? --> --------- Signed-off-by: Lukasz Dziedziak <[email protected]>
- Loading branch information
1 parent
7fb2695
commit f58221c
Showing
4 changed files
with
58 additions
and
1 deletion.
There are no files selected for viewing
1 change: 1 addition & 0 deletions
1
...s/policies/meshtimeout/plugin/testdata/basic_without_defaults_inbound_cluster.golden.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
name: localhost:8080 |
32 changes: 32 additions & 0 deletions
32
.../policies/meshtimeout/plugin/testdata/basic_without_defaults_inbound_listener.golden.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
address: | ||
socketAddress: | ||
address: 127.0.0.1 | ||
portValue: 80 | ||
enableReusePort: false | ||
filterChains: | ||
- filters: | ||
- name: envoy.filters.network.http_connection_manager | ||
typedConfig: | ||
'@type': type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager | ||
httpFilters: | ||
- name: envoy.filters.http.router | ||
typedConfig: | ||
'@type': type.googleapis.com/envoy.extensions.filters.http.router.v3.Router | ||
routeConfig: | ||
name: inbound:backend | ||
requestHeadersToRemove: | ||
- x-kuma-tags | ||
validateClusters: false | ||
virtualHosts: | ||
- domains: | ||
- '*' | ||
name: backend | ||
routes: | ||
- match: | ||
prefix: / | ||
route: | ||
cluster: backend | ||
timeout: 0s | ||
statPrefix: inbound_127_0_0_1_80 | ||
name: inbound:127.0.0.1:80 | ||
trafficDirection: INBOUND |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters