Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a sleep after service delete to allow NEGs get garbage collected. #2981

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a sleep after service delete to allow NEGs get garbage collected. #2981

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions clusterloader2/testing/neg/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,3 +118,9 @@ steps:
Method: WaitForControlledPodsRunning
Params:
action: gather
- name: Wait 15 minutes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: rename to "Wait after deletion" or similar

measurements:
- Identifier: Wait
Method: Sleep
Params:
duration: 15m
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest parametrizing the sleep duration value, so that separate tests can have a custom wait at the end. This will allow more accurate test configurations, and won’t require making changes to the test manifests in this repo.

Check out the CL2 params at top of the file, and add one such.
For example:

{{$waitAfterDeletion := DefaultParam .CL2_WAIT_AFTER_DELETION “15m”}}
...
- name: Wait after deletion
  measurements:
    - Identifier: Wait
      Method: Sleep
      Params:
        duration: {{$waitAfterDeletion}}

Please retest it before submitting.