Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a sleep after service delete to allow NEGs get garbage collected. #2981

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sawsa307
Copy link

@sawsa307 sawsa307 commented Nov 7, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

Currently NEG scale tests fail during test suite cleanup because the cluster network cannot be deleted while there are NEGs referencing it. NEG garbage collect happens asynchronously after k8s services are deleted, so we need to add a wait and allow NEGs to be cleaned up before we attempt to delete the network.

Which issue(s) this PR fixes:

Fixes ci-kubernetes-e2e-gke-rapid-300-neg-performance.Overall

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sawsa307
Once this PR has been reviewed and has the lgtm label, please assign wojtek-t for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sawsa307
Copy link
Author

sawsa307 commented Nov 7, 2024

/assign @dlapcevic

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 7, 2024
- Identifier: Wait
Method: Sleep
Params:
duration: 15m
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest parametrizing the sleep duration value, so that separate tests can have a custom wait at the end. This will allow more accurate test configurations, and won’t require making changes to the test manifests in this repo.

Check out the CL2 params at top of the file, and add one such.
For example:

{{$waitAfterDeletion := DefaultParam .CL2_WAIT_AFTER_DELETION “15m”}}
...
- name: Wait after deletion
  measurements:
    - Identifier: Wait
      Method: Sleep
      Params:
        duration: {{$waitAfterDeletion}}

Please retest it before submitting.

@@ -118,3 +118,9 @@ steps:
Method: WaitForControlledPodsRunning
Params:
action: gather
- name: Wait 15 minutes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: rename to "Wait after deletion" or similar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants