Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding the variable KNATIVE_EVENTING_RELEASE_TLS to install latest eventing TLS #350

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Adding the variable KNATIVE_EVENTING_RELEASE_TLS to install latest eventing TLS #350

merged 2 commits into from
Nov 22, 2023

Conversation

Leo6Leo
Copy link
Member

@Leo6Leo Leo6Leo commented Nov 22, 2023 •
edited
Loading

Changes

  • Adding the KNATIVE_EVENTING_RELEASE_TLS

Release Note

Adding the option to install knative eventing TLS component

Docs

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 22, 2023
@Leo6Leo Leo6Leo changed the title Adding the variable to install latest eventing tls Adding the variable KNATIVE_EVENTING_RELEASE_TLS to install latest eventing TLS Nov 22, 2023
@Leo6Leo
Copy link
Member Author

Leo6Leo commented Nov 22, 2023

/cc @pierDipi

@knative-prow knative-prow bot requested a review from pierDipi November 22, 2023 17:00
pierDipi
pierDipi reviewed Nov 22, 2023
View reviewed changes
library.sh Outdated Show resolved Hide resolved
@pierDipi
Copy link
Member

One comment

/approve

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2023
@Leo6Leo @pierDipi
Update library.sh
7e330b7 
Co-authored-by: Pierangelo Di Pilato <[email protected]>
@Leo6Leo
Copy link
Member Author

Leo6Leo commented Nov 22, 2023

/cc @Cali0707

@knative-prow knative-prow bot requested a review from Cali0707 November 22, 2023 17:22
@Leo6Leo Leo6Leo mentioned this pull request Nov 22, 2023
Merged
Cali0707
Cali0707 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2023
@knative-prow Knative Prow
Copy link

knative-prow bot commented Nov 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, Leo6Leo, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit eb35242 into knative:main Nov 22, 2023
6 checks passed
@Leo6Leo
Copy link
Member Author

Leo6Leo commented Nov 22, 2023

/cherry-pick release-1.11

@knative-prow-robot
Copy link

@Leo6Leo: new pull request created: #351

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Nov 22, 2023
Merged
@Leo6Leo
Copy link
Member Author

Leo6Leo commented Nov 22, 2023

/cherry-pick release-1.12

@knative-prow-robot
Copy link

@Leo6Leo: new pull request created: #352

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Nov 22, 2023
Merged
@knative-prow-robot
Copy link

@Leo6Leo: #350 failed to apply on top of branch "release-1.12":

Applying: Adding the variable to install latest eventing tls
Using index info to reconstruct a base tree...
M	library.sh
Falling back to patching base and 3-way merge...
Auto-merging library.sh
CONFLICT (content): Merge conflict in library.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Adding the variable to install latest eventing tls
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi left review comments

@Cali0707 Cali0707 Cali0707 approved these changes

@evankanderson evankanderson Awaiting requested review from evankanderson

@krsna-m krsna-m Awaiting requested review from krsna-m

Assignees

@Cali0707 Cali0707

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Leo6Leo @pierDipi @knative-prow-robot @Cali0707