[release-1.11] Cherry-pick E2E tests for broker: TLS key pair rotation #3287 #3387

Leo6Leo · 2023-10-10T15:57:13Z

Cherry-pick https://github.com/knative-extensions/eventing-kafka-broker/pull/3287/files

Unblocked when knative/hack#350 is merged.

* progress save * add the new cert rotation test * Update the rekt test * Format the files * workspace save * maven * Clean up * Clean up * Format * Fix the rekt test CA cert issue on Source Co-authored-by: Pierangelo Di Pilato <[email protected]> * Format fix * Re-order the prerequisite * Enable the strict transportation mode in TLS rekt tests * Fix the reviewDog comment * Update test/e2e_new/broker_eventing_tls_test.go Co-authored-by: Pierangelo Di Pilato <[email protected]> * Fix the format of the shell script * Fix the format of the shell script * Update the Strict feature flag * Add the code to inject the feature flag to the context in the broker controller * Run go import * Fix the controller tests * Set the default value to all other feature flags when we are updating the transport-encryption feature flag --------- Co-authored-by: Pierangelo Di Pilato <[email protected]> Co-authored-by: Pierangelo Di Pilato <[email protected]>

Leo6Leo · 2023-10-10T15:57:52Z

/cc @Cali0707 @creydr

codecov · 2023-10-10T16:06:33Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (67fc0ea) 58.49% compared to head (9322c67) 80.14%.
Report is 1 commits behind head on release-1.11.

Additional details and impacted files

@@                 Coverage Diff                 @@
##             release-1.11    #3387       +/-   ##
===================================================
+ Coverage           58.49%   80.14%   +21.64%     
- Complexity              0      768      +768     
===================================================
  Files                  91       78       -13     
  Lines                9163     2780     -6383     
  Branches                0      247      +247     
===================================================
- Hits                 5360     2228     -3132     
+ Misses               3382      397     -2985     
+ Partials              421      155      -266

Flag	Coverage Δ
java-unittests	`80.14% <100.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Leo6Leo · 2023-10-11T19:08:39Z

/retest-required

Cali0707 · 2023-10-19T14:58:10Z

/retest-required

Cali0707 · 2023-10-19T16:29:56Z

@Leo6Leo can you look into why the kafka-source-dispatcher pod is not coming live?

Leo6Leo · 2023-11-23T21:23:45Z

/retest-required

Leo6Leo · 2023-11-24T13:43:03Z

/retest-required

Leo6Leo · 2023-11-24T15:49:20Z

/cc @pierDipi

data-plane/THIRD-PARTY.txt

data-plane/pom.xml

…8-release-1.11

Leo6Leo · 2023-11-28T20:18:37Z

/retest-required

Leo6Leo · 2023-11-29T14:11:33Z

/retest-required

pierDipi

/lgtm
/approve

knative-prow · 2023-11-29T15:06:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leo6Leo, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Leo6Leo · 2023-11-29T16:44:18Z

/retest-required

Leo6Leo · 2023-11-29T18:50:51Z

/retest-required

Leo6Leo · 2023-11-29T21:32:39Z

/retest-required

Leo6Leo · 2023-11-30T18:50:25Z

/cherry-pick release-1.12

knative-prow-robot · 2023-11-30T18:51:02Z

@Leo6Leo: #3387 failed to apply on top of branch "release-1.12":

Applying: E2E tests for broker: TLS key pair rotation (#3287)
Using index info to reconstruct a base tree...
M	control-plane/pkg/reconciler/broker/controller.go
M	control-plane/pkg/reconciler/broker/controller_test.go
M	data-plane/core/src/main/java/dev/knative/eventing/kafka/broker/core/metrics/Metrics.java
M	test/reconciler-tests.sh
M	test/rekt/features/broker_auth.go
Falling back to patching base and 3-way merge...
Auto-merging test/reconciler-tests.sh
Auto-merging control-plane/pkg/reconciler/broker/controller.go
No changes -- Patch already applied.
Applying: Run Dependency update
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
M	vendor/knative.dev/eventing/hack/update-cert-manager.sh
M	vendor/knative.dev/reconciler-test/pkg/environment/magic.go
M	vendor/knative.dev/reconciler-test/pkg/environment/namespace.go
M	vendor/knative.dev/reconciler-test/pkg/eventshub/eventshub.go
M	vendor/knative.dev/reconciler-test/pkg/eventshub/forwarder/forwarder.go
M	vendor/knative.dev/reconciler-test/pkg/eventshub/resources.go
M	vendor/knative.dev/reconciler-test/pkg/manifest/manifest.go
M	vendor/knative.dev/reconciler-test/pkg/manifest/options.go
M	vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
CONFLICT (content): Merge conflict in vendor/modules.txt
Auto-merging vendor/knative.dev/reconciler-test/pkg/eventshub/resources.go
Auto-merging vendor/knative.dev/reconciler-test/pkg/eventshub/forwarder/forwarder.go
CONFLICT (content): Merge conflict in vendor/knative.dev/reconciler-test/pkg/eventshub/forwarder/forwarder.go
Auto-merging vendor/knative.dev/reconciler-test/pkg/environment/magic.go
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Run Dependency update
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow bot added the area/control-plane label Oct 10, 2023

knative-prow bot requested review from matzew and pierDipi October 10, 2023 15:57

knative-prow bot added area/data-plane size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/test labels Oct 10, 2023

knative-prow bot requested review from Cali0707 and creydr October 10, 2023 15:57

knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 10, 2023

Leo6Leo force-pushed the cp-933098d78-release-1.11 branch from 4c5cc4c to 0e56fb1 Compare October 10, 2023 17:13

knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 10, 2023

Run Dependency update

cf72d91

knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 10, 2023

Leo6Leo added 3 commits October 11, 2023 09:10

Upgrade Knative eventing to release-1.11

348bc3f

Upgrade Knative eventing to release-1.11

885f384

Upgrade Knative eventing to release-1.11

d702f67

knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 11, 2023

Leo6Leo mentioned this pull request Oct 20, 2023

E2E tests for broker: TLS key pair rotation #3287

Merged

10 tasks

Merge the upstream release 1.11

4f56b0a

knative-prow bot removed the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 30, 2023

Leo6Leo added 2 commits November 23, 2023 14:41

Update missed dependencies

8588726

Update codegen

f9fae51

knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 23, 2023

knative-prow bot requested a review from pierDipi November 24, 2023 15:49

pierDipi reviewed Nov 28, 2023

View reviewed changes

data-plane/THIRD-PARTY.txt Outdated Show resolved Hide resolved

pierDipi reviewed Nov 28, 2023

View reviewed changes

data-plane/pom.xml Outdated Show resolved Hide resolved

Leo6Leo added 2 commits November 28, 2023 13:19

Merge remote-tracking branch 'upstream/release-1.11' into cp-933098d7…

8f19a8b

…8-release-1.11

Revert the dependency version to the latest

9322c67

knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 28, 2023

Leo6Leo changed the title ~~[WIP][release-1.11] Cherry-pick E2E tests for broker: TLS key pair rotation #3287~~ [release-1.11] Cherry-pick E2E tests for broker: TLS key pair rotation #3287 Nov 29, 2023

knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2023

pierDipi approved these changes Nov 29, 2023

View reviewed changes

knative-prow bot assigned pierDipi Nov 29, 2023

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2023

knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2023

knative-prow bot requested a review from pierDipi November 29, 2023 22:51

knative-prow bot merged commit f6481d7 into knative-extensions:release-1.11 Nov 29, 2023
33 of 36 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release-1.11] Cherry-pick E2E tests for broker: TLS key pair rotation #3287 #3387

[release-1.11] Cherry-pick E2E tests for broker: TLS key pair rotation #3287 #3387

Leo6Leo commented Oct 10, 2023 •

edited

Loading

Leo6Leo commented Oct 10, 2023

codecov bot commented Oct 10, 2023 •

edited

Loading

Leo6Leo commented Oct 11, 2023

Cali0707 commented Oct 19, 2023

Cali0707 commented Oct 19, 2023

Leo6Leo commented Nov 23, 2023

Leo6Leo commented Nov 24, 2023

Leo6Leo commented Nov 24, 2023

Leo6Leo commented Nov 28, 2023

Leo6Leo commented Nov 29, 2023

pierDipi left a comment

knative-prow bot commented Nov 29, 2023

Leo6Leo commented Nov 29, 2023

Leo6Leo commented Nov 29, 2023

Leo6Leo commented Nov 29, 2023

Leo6Leo commented Nov 30, 2023

knative-prow-robot commented Nov 30, 2023

[release-1.11] Cherry-pick E2E tests for broker: TLS key pair rotation #3287 #3387

[release-1.11] Cherry-pick E2E tests for broker: TLS key pair rotation #3287 #3387

Conversation

Leo6Leo commented Oct 10, 2023 • edited Loading

Leo6Leo commented Oct 10, 2023

codecov bot commented Oct 10, 2023 • edited Loading

Codecov Report

Leo6Leo commented Oct 11, 2023

Cali0707 commented Oct 19, 2023

Cali0707 commented Oct 19, 2023

Leo6Leo commented Nov 23, 2023

Leo6Leo commented Nov 24, 2023

Leo6Leo commented Nov 24, 2023

Leo6Leo commented Nov 28, 2023

Leo6Leo commented Nov 29, 2023

pierDipi left a comment

Choose a reason for hiding this comment

knative-prow bot commented Nov 29, 2023

Leo6Leo commented Nov 29, 2023

Leo6Leo commented Nov 29, 2023

Leo6Leo commented Nov 29, 2023

Leo6Leo commented Nov 30, 2023

knative-prow-robot commented Nov 30, 2023

Leo6Leo commented Oct 10, 2023 •

edited

Loading

codecov bot commented Oct 10, 2023 •

edited

Loading