Introducing common integration helper and change package name #6896
matzewknative-style.yaml
on: pull_request
style
/
changes
4s
style
/
...
/
Auto-format and Check
18s
style
/
...
/
Lint
4m 8s
style
/
...
/
Do Not Submit
8s
style
/
...
/
shell
0s
style
/
...
/
yaml
20s
style
/
...
/
github_actions
0s
Matrix: style / Golang / Boilerplate Check
Annotations
7 errors and 4 warnings
|
style / Golang / Auto-format and Check:
cmd/controller/main.go#L1
Please run goimports.
diff --git a/cmd/controller/main.go b/cmd/controller/main.go
index 68d19d5..e8cbe89 100644
--- a/cmd/controller/main.go
+++ b/cmd/controller/main.go
@@ -21,12 +21,13 @@ import (
// _ "k8s.io/client-go/plugin/pkg/client/auth/gcp"
"errors"
- "knative.dev/eventing/pkg/reconciler/integration/source"
"log"
"net/http"
"os"
"time"
+ "knative.dev/eventing/pkg/reconciler/integration/source"
+
"knative.dev/pkg/injection/sharedmain"
filteredFactory "knative.dev/pkg/client/injection/kube/informers/factory/filtered"
|
|
style / Golang / Auto-format and Check:
pkg/apis/sources/v1alpha1/integration_types_test.go#L1
Please run goimports.
diff --git a/pkg/apis/sources/v1alpha1/integration_types_test.go b/pkg/apis/sources/v1alpha1/integration_types_test.go
index 4dfd20e..ad30b14 100644
--- a/pkg/apis/sources/v1alpha1/integration_types_test.go
+++ b/pkg/apis/sources/v1alpha1/integration_types_test.go
@@ -17,8 +17,9 @@ limitations under the License.
package v1alpha1
import (
- "knative.dev/eventing/pkg/apis/common/integration/v1alpha1"
"testing"
+
+ "knative.dev/eventing/pkg/apis/common/integration/v1alpha1"
)
func TestIntegrationSource_GetStatus(t *testing.T) {
|
|
style / Golang / Auto-format and Check:
pkg/apis/sources/v1alpha1/integration_validation_test.go#L1
Please run goimports.
diff --git a/pkg/apis/sources/v1alpha1/integration_validation_test.go b/pkg/apis/sources/v1alpha1/integration_validation_test.go
index 3281b39..9b26342 100644
--- a/pkg/apis/sources/v1alpha1/integration_validation_test.go
+++ b/pkg/apis/sources/v1alpha1/integration_validation_test.go
@@ -18,9 +18,10 @@ package v1alpha1
import (
"context"
- "knative.dev/eventing/pkg/apis/common/integration/v1alpha1"
"testing"
+ "knative.dev/eventing/pkg/apis/common/integration/v1alpha1"
+
"github.com/google/go-cmp/cmp"
"knative.dev/pkg/apis"
)
|
|
style / Golang / Auto-format and Check:
pkg/reconciler/integration/source/integrationsource.go#L1
Please run goimports.
diff --git a/pkg/reconciler/integration/source/integrationsource.go b/pkg/reconciler/integration/source/integrationsource.go
index c466058..ef94fd2 100644
--- a/pkg/reconciler/integration/source/integrationsource.go
+++ b/pkg/reconciler/integration/source/integrationsource.go
@@ -19,6 +19,7 @@ package source
import (
"context"
"fmt"
+
"knative.dev/eventing/pkg/reconciler/integration/source/resources"
"go.uber.org/zap"
|
|
style / Golang / Auto-format and Check
Process completed with exit code 1.
|
|
style / Golang / Lint:
pkg/reconciler/integration/helper.go#L28
const `prefix` is unused (unused)
|
|
style / Golang / Lint
issues found
|
|
style / Golang / Auto-format and Check
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
|
|
style / Golang / Boilerplate Check (go)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
|
|
style / Golang / Boilerplate Check (sh)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
|
|
style / Golang / Lint
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
|