Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introducing common integration helper and change package name #8327

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Introducing common integration helper and change package name #8327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e1c6af6
Update API and use custom tags on structs
matzew Nov 8, 2024
84c5911
Moving API to a versioned common/integration folder
matzew Nov 13, 2024
acc2146
create new integration/source folder and factor common code into help…
matzew Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/controller/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/*

Check failure on line 1 in cmd/controller/main.go

View workflow job for this annotation

GitHub Actions / style / Golang / Auto-format and Check 

Please run goimports.
diff --git a/cmd/controller/main.go b/cmd/controller/main.go
index 68d19d5..e8cbe89 100644
--- a/cmd/controller/main.go
+++ b/cmd/controller/main.go
@@ -21,12 +21,13 @@ import (
 	// _ "k8s.io/client-go/plugin/pkg/client/auth/gcp"
 
 	"errors"
-	"knative.dev/eventing/pkg/reconciler/integration/source"
 	"log"
 	"net/http"
 	"os"
 	"time"
 
+	"knative.dev/eventing/pkg/reconciler/integration/source"
+
 	"knative.dev/pkg/injection/sharedmain"
 
 	filteredFactory "knative.dev/pkg/client/injection/kube/informers/factory/filtered"
Copyright 2019 The Knative Authors

Licensed under the Apache License, Version 2.0 (the "License");
Expand All @@ -21,6 +21,7 @@
// _ "k8s.io/client-go/plugin/pkg/client/auth/gcp"

"errors"
"knative.dev/eventing/pkg/reconciler/integration/source"
"log"
"net/http"
"os"
Expand All @@ -41,7 +42,6 @@
"knative.dev/eventing/pkg/reconciler/channel"
"knative.dev/eventing/pkg/reconciler/containersource"
"knative.dev/eventing/pkg/reconciler/eventtype"
"knative.dev/eventing/pkg/reconciler/integrationsource"
"knative.dev/eventing/pkg/reconciler/parallel"
"knative.dev/eventing/pkg/reconciler/pingsource"
"knative.dev/eventing/pkg/reconciler/sequence"
Expand Down Expand Up @@ -105,7 +105,7 @@
apiserversource.NewController,
pingsource.NewController,
containersource.NewController,
integrationsource.NewController,
source.NewController,

// Sources CRD
sourcecrd.NewController,
Expand Down
8 changes: 4 additions & 4 deletions config/core/resources/integrationsource.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ spec:
s3:
type: object
properties:
bucketNameOrArn:
arn:
type: string
title: Bucket Name
description: The S3 Bucket name or Amazon Resource Name (ARN).
Expand Down Expand Up @@ -199,7 +199,7 @@ spec:
sqs:
type: object
properties:
queueNameOrArn:
arn:
type: string
title: Queue Name
description: The SQS Queue Name or ARN
Expand All @@ -217,7 +217,7 @@ spec:
title: Autocreate Queue
description: Setting the autocreation of the SQS queue.
default: false
amazonAWSHost:
host:
type: string
title: AWS Host
description: The hostname of the Amazon AWS cloud.
Expand Down Expand Up @@ -287,7 +287,7 @@ spec:
description: The duration (in seconds) that the received messages are
hidden from subsequent retrieve requests after being retrieved by
a ReceiveMessage request.
ddb-streams:
ddbStreams:
type: object
properties:
table:
Expand Down
Loading
Loading