Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[global_unity_controller] Fix dispose not called #769

Open
wants to merge 1 commit into
base: feat/global_unity_controller
Choose a base branch
from
Open

[global_unity_controller] Fix dispose not called #769

wants to merge 1 commit into from

Conversation

Ortes
Copy link
Contributor

@Ortes Ortes commented Feb 16, 2023

Description

Call dispose for both FlutterUnityController and FlutterUnityPlatform

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@Ortes Ortes mentioned this pull request Feb 16, 2023
Closed
@timbotimbo
Copy link
Collaborator

Given the changes and the fact that this merges into feat/global_unity_controller, this seems specific to that branch.
I'll add a mention to the original pull request and update the title, to make this easier to see.

Looks like this fixes regression number 1 mentioned here

@timbotimbo timbotimbo changed the title Fix dispose not called [global_unity_controller] Fix dispose not called Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ortes @timbotimbo