Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: drop Node 4, 6, 8, 10, 12, 14 & 16 support #141

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: drop Node 4, 6, 8, 10, 12, 14 & 16 support #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions .github/workflows/node-aught.yml
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions .github/workflows/node-tens.yml → .github/workflows/node.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
name: 'Tests: node.js >= 10'
name: 'Tests: node.js 18+'

on: [pull_request, push]

jobs:
tests:
uses: ljharb/actions/.github/workflows/node.yml@main
with:
range: '>= 10'
range: '^18.18.0 || ^20.9.0 || >=21.1.0'
type: minors
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node 22 is out, so maybe don't need to support Node 21, which is unstable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've set node.engines to the same as ESLint is doing, but I'm happy to update if @ljharb wants to

command: npm run tests-only

node:
name: 'node >= 10'
name: 'node 18+'
needs: [tests]
runs-on: ubuntu-latest
steps:
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"safe-publish-latest": "^2.0.0"
},
"engines": {
"node": ">=4.0"
"node": "^18.18.0 || ^20.9.0 || >=21.1.0"
},
"keywords": [
"jsx",
Expand Down
Loading