feat: drop Node 4, 6, 8, 10, 12, 14 & 16 support #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Requires Node@^18.18.0 || ^20.9.0 || >=21.1.0
|
@ljharb Settings should be updated to make |
benmccann
reviewed
Oct 28, 2024
|
|
||
| on: [pull_request, push] | ||
|
|
||
| jobs: | ||
| tests: | ||
| uses: ljharb/actions/.github/workflows/node.yml@main | ||
| with: | ||
| range: '>= 10' | ||
| range: '^18.18.0 || ^20.9.0 || >=21.1.0' |
There was a problem hiding this comment.
Node 22 is out, so maybe don't need to support Node 21, which is unstable?
There was a problem hiding this comment.
I've set node.engines to the same as ESLint is doing, but I'm happy to update if @ljharb wants to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @ljharb mentioned in #114 (comment), he's open for a breaking change right now
BREAKING CHANGE: Requires Node@^18.18.0 || ^20.9.0 || >=21.1.0