-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5] add host database port #43926
[5] add host database port #43926
Conversation
Thank you @alikon for this draft PR, I added a language overwrite and did a picture: There are arguments for (e.g. using
Why do we need backwards compatibility here? And there is no hurry, from my point of view we can have it 5.2. Another point: I would make the field optional and blank by default if the default database port is used. This again for simplicity: If we display the default port number, then we have to change it when the database is changed. |
I like the idea behind this PR, but I don't think it makes sense to make the field required. |
with joomla-framework/database#310 no more needed in cypress.config.mjs |
Draft partial Pull Request for Feature request #43902 .
Summary of Changes
add db host port filed
Testing Instructions
ìnstall and play with different setup db hostname and db port
Actual result BEFORE applying this Pull Request
postgres pdo doesn't work if port different from default (5432)
Expected result AFTER applying this Pull Request
you can set a db port
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed