Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add db_port #34

Closed
wants to merge 1 commit into from
Closed

add db_port #34

wants to merge 1 commit into from

Conversation

alikon
Copy link

@alikon alikon commented Aug 25, 2024

@muhme
Copy link
Contributor

muhme commented Aug 25, 2024

This fails as changes in the Joomla Web Installer needs to be implemented first:

 AssertionError: Timed out retrying after 4000ms: Expected to find element: `#jform_db_port`, but never found it.

In my opinion, each piece of the puzzle must first work independently, as there are far too many dependencies:

  • joomla-cypress changes and creating a new release
  • Using joomla-cypress new release in Joomla dev branch
  • Change in Joomla Systems Tests
  • Changes in Joomla Web Installer
  • Change in the backend administration screen

And as ?fun fact?, with #33 there is an intermediate solution submitted for != pgsql with using the port if it is given

And why is db_port used in setErrorReportingToDevelopment?

@muhme muhme mentioned this pull request Aug 31, 2024
Open
@alikon
Copy link
Author

alikon commented Sep 1, 2024

with joomla-framework/database#310 no more needed

@alikon alikon closed this Sep 1, 2024
@alikon alikon deleted the patch-1 branch September 1, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alikon @muhme