Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UnitOfWork #175

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Add UnitOfWork #175

merged 3 commits into from
Oct 1, 2024

Conversation

liptakpanna
Copy link
Contributor

@utnapischtim
Copy link
Contributor

could you please add some tests to that addition. i am working to update the dependencies of this package. it would help to have tests for this change too.

Copy link

@carlinmack carlinmack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + @0einstein0 😸

Copy link
Contributor

@ntarocco ntarocco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Before merging and releasing, did you remove the original code from invenio-records-resources and made the imports compatible?

@ntarocco ntarocco merged commit bc44ec5 into inveniosoftware:master Oct 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants