uow: import from invenio_db #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptamarit
approved these changes
Oct 1, 2024
ptamarit
reviewed
Oct 1, 2024
| @@ -8,6 +8,8 @@ | |||
|
|
|||
| """Unit of work. | |||
|
|
|||
| Classes were moved to invenio-db. | |||
|
|
|||
| Used to group multiple service operations into a single atomic unit. The Unit | |||
There was a problem hiding this comment.
All these comments should probably be removed from here to avoid duplication (and one of them getting stale).
Maybe something like: For documentation see ...
There was a problem hiding this comment.
There are some parts which are specific to the classes that remained in this module and in invenio_db I modified the comment so it's only about the functionalities that I copied over and can be used from there.
There was a problem hiding this comment.
OK, I thought it was an exact copy-paste, but I now see that it's been adapted.
I think it's fine, this part of the code did not change much over the years, and people should think about updating if there are every big changes.
ntarocco
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit of work classes which were not related to Records, Tasks, Indexes were moved to invenio_db: inveniosoftware/invenio-db#175
The goal was that the import would still work from other modules.