Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue1744 option for non-constant TGround in equivalent air temperature (VDI 6007) #1749

Merged
merged 4 commits into from
Sep 14, 2023
Merged

issue1744 option for non-constant TGround in equivalent air temperature (VDI 6007) #1749

merged 4 commits into from
Sep 14, 2023

Conversation

PGorzalka
Copy link

This should solve #1744

@PGorzalka
Added an option for non-constant ground temperature from an input con…
161050c 
…nector in ThermalZones.ReducedOrder.EquivalentAirTemperature.
@PGorzalka PGorzalka mentioned this pull request May 10, 2023
Closed
@PGorzalka PGorzalka changed the title Option for non-constant TGround in equivalent air temperature (VDI 6007) Option for non-constant TGround in equivalent air temperature (VDI 6007), #1744 May 10, 2023
@PGorzalka PGorzalka changed the title Option for non-constant TGround in equivalent air temperature (VDI 6007), #1744 issue1744 option for non-constant TGround in equivalent air temperature (VDI 6007) May 10, 2023
mwetter
mwetter requested changes May 11, 2023
View reviewed changes
Copy link
Contributor

@mwetter mwetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PGorzalka : The changes look good. Can you please also add an example or validation test that uses this new option. This way it will become part of the CI testing.

@PGorzalka
Copy link
Author

@mwetter I added the example including reference results. After running the unit tests locally (only for ROM), IBPSA.ThermalZones.ReducedOrder.Validation.VDI6007.TestCase7 is only 80 % successful on my machine. I assume this is due to numeric errors/compiler differences, because my changes should not affect that test case at all.

Please let me know if there is anything I missed or did not do as it's supposed to be done.

@mwetter mwetter changed the base branch from master to issue1744_vdi6007-non-constant-t-ground September 14, 2023 14:44
@mwetter
Copy link
Contributor

mwetter commented Sep 14, 2023

@PGorzalka : Thanks, I will move it to a development branch and then do a further review, likely finishing next week.

@mwetter mwetter merged commit ca1d4d7 into ibpsa:issue1744_vdi6007-non-constant-t-ground Sep 14, 2023
1 check failed
@mwetter
Copy link
Contributor

mwetter commented Sep 14, 2023

The unit tests look good, the differences are likely due to Windows vs Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwetter mwetter mwetter requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PGorzalka @mwetter