-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option for non-constant TGround in equivalent air temperature (VDI 6007) #1744
Comments
That would be a good addition. However for consistency with |
Thank you for the feedback. I implemented this in pull request 1749. As this is my first contribution here, I hope I did it as intended by the guidelines. |
Being basically finished with this issue (just missing a Dymola update to run the unit tests), I would like to bring up a related topic. Currently, the model calculates the equivalent temperature lumping surfaces in contact to air and to the soil (where
where where In these equations, However, While I am sure that
Regarding point 2, I checked this with the district I am currently working on. Point 3 is not that important I think. Yes, some cosines need to be calculated, but only during initalization, so the added calculation complexity is very small (there was no change in calculation time for my example). Point 1 is certainly valid, but equally valid for the soil temperature, and TTer might be calculated by some external model (or, in Germany, taken from the weather files). So, as a consequence, I would like to introduce the more complex equation from VDI 6007, of course keeping the default behaviour as it is. In my opinion, the naming of the model referencing the guideline directly is a little misleading if it does not completely follow the equations presented there. Of course, I would keep the default behaviour. @mwetter What do you think about this, would this be a valuable contribution here? And if yes, would it make sense to add it to the existing pull request or should I open a new issue? @DaJansenGit FYI |
@PGorzalka : Having as an option the more detailed equation seems fine to me; however I don't quite understand how a user would use it as If you move forward with it, I suggest you make a new branch based on your PR. This way, the two contributions can be reviewed separately once you finished #1749 (which I believe still has pending issues to be resolved). |
@mwetter : It depends... from the German TRY datasets, it is available. I do not know if other institutions also publish similar data - with search terms in English, I could not find any. However, historical data is available e.g. for global hourly land surface temperatures ranging from July 2021 to today. A model to calculate typical Regarding the separate branch, I already did so. I will create a new pull request if I'm finished with everything. Pending issue is just that the tests require a Dymola update on my PC, which requires an update of our license server, which requires our IT admin to return from holidays :) |
Hi,
Issue 1080 of AixLib intends to add non-constant soil temperatures to the reduced-order model. Regarding the RC model itself, this does not affect IBPSA. However, the equivalent air temperature calculation models currently only allow a constant ground temperature parameter.
I would like to suggest adding a variable
TGroundUsed
inThermalZones.ReducedOrder.EquivalentAirTemperature.BaseClasses.PartialVDI6007
that is used for the calculations inVDI6007
andVDI6007WithWindow
and gets the value from one of the optionsTGro
(current constant parameter)TGround
(input connector to be added)depending on another Boolean parameter to be added which is by default pointing to
TGro
.Looking forward to hearing your thoughts about this.
The text was updated successfully, but these errors were encountered: