Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1080 ROM soil temperature and interzonal heat exchange #1546

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

PGorzalka
Copy link

@PGorzalka PGorzalka commented Nov 17, 2024

Finally, I was able to finish the work on issue #1080
@DaJansenGit & @FWuellhorst thanks for your support!

Changes mainly encompass the work mentioned in this paper:

  • building up on changes already implemented via IBPSA merge, some adaptations for non-constant soil temperature
    • Option selector added to AixLib.BoundaryConditions
    • Options added to ZoneBaseRecord
    • Replaced TSoil constant in ThermalZone by option selector
  • Interzonal heat exchange with new FiveElements RC model
    • Integration of that model into ThermalZone
    • Interzonal connection of zones in Multizone. For OM compatibility, I had to add an additional NzSplitter model and parameters to make sure arrays are initialized without errors.
    • Added ASHRAE test case 960

Additional minor stuff:

  • made some parts of the ThermalZone model replaceable, so boundary conditions can be adapted more easily
  • two missing eachs in AixLib.Fluid.Pools.BaseClasses.AirFlowMoistureToROM caused OM to fail -> fixed

Missing:

  • Test Case 960 was not actually tested against standard results because the weather file provided (AixLib\Resources\weatherdata\ASHRAE140.mos) does not contain the weather data provided by the standard.

See also PR 785 in TEASER

Looking forward to your feedback on the changes!

PGorzalka and others added 19 commits April 20, 2023 11:07
…VDI6007 calculators. Made some elements in ThermalZone replaceable for future implementation of e.g. urban shading.
…n GroundTemperature/GroundTemperatureOptions.mo
FiveElements: bug fixed and documentation updated.
done:
- ROM RC module including pass-through
- connection between zones via additional NzSplitter.mo
…delica

left to do: remove redundant heatFlowSensor
@FWuellhorst
Copy link
Contributor

@PGorzalka , nice, thanks for adding this nice feature to AixLib! We have an extensive CI which does a lot of groundwork of the review, but it only runs for internal branches. Thus, I added an internal branch based on your fork. Now, we see if naming guidelines and regression tests all run. Depending on the changes, you either can work in your fork and merge your fork into the internal branch, or we could add you as a developer so you can work directly in AixLib @DaJansenGit ?

@FWuellhorst FWuellhorst mentioned this pull request Nov 18, 2024
@DaJansenGit
Copy link
Member

DaJansenGit commented Nov 18, 2024

@PGorzalka thanks for contributing!
@FWuellhorst Lets see what the CI outputs. If there are bigger changes that need to be addressed, I would add Philip as developer. Thanks for creating the CI branch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants