-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue1080 ROM soil temperature and interzonal heat exchange #1546
base: main
Are you sure you want to change the base?
Issue1080 ROM soil temperature and interzonal heat exchange #1546
Conversation
…r implementation to ROM
…VDI6007 calculators. Made some elements in ThermalZone replaceable for future implementation of e.g. urban shading.
…n GroundTemperature/GroundTemperatureOptions.mo
FiveElements: bug fixed and documentation updated.
…ub.com/RWTH-EBC/AixLib' into issue1080_ROM-soil-and-zone-borders
done: - ROM RC module including pass-through - connection between zones via additional NzSplitter.mo
…ween indoor RC surfaces
…delica left to do: remove redundant heatFlowSensor
added ASHRAE140 test case 960
…-soil-and-zone-borders
@PGorzalka , nice, thanks for adding this nice feature to AixLib! We have an extensive CI which does a lot of groundwork of the review, but it only runs for internal branches. Thus, I added an internal branch based on your fork. Now, we see if naming guidelines and regression tests all run. Depending on the changes, you either can work in your fork and merge your fork into the internal branch, or we could add you as a developer so you can work directly in AixLib @DaJansenGit ? |
@PGorzalka thanks for contributing! |
Finally, I was able to finish the work on issue #1080
@DaJansenGit & @FWuellhorst thanks for your support!
Changes mainly encompass the work mentioned in this paper:
Additional minor stuff:
each
s inAixLib.Fluid.Pools.BaseClasses.AirFlowMoistureToROM
caused OM to fail -> fixedMissing:
See also PR 785 in TEASER
Looking forward to your feedback on the changes!