Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROM: non-constant soil temperature #1080

Open
PGorzalka opened this issue Feb 25, 2021 · 12 comments
Open

ROM: non-constant soil temperature #1080

PGorzalka opened this issue Feb 25, 2021 · 12 comments
Assignees

Comments

@PGorzalka
Copy link

PGorzalka commented Feb 25, 2021

What is the problem?

  • ROM thermal zone currently only supports constant values for TSoil ("Outdoor surface temperature for floor plate")
  • Validation of the model in a case study required using this value equivalent to weather data

How do we want to solve it? Describe the solution you'd like

  • Conditional in ZoneBaseRecord that causes a switch between the (default) constant value and a new port for TSoil, which is passed through Multizone
  • A time table of soil temperatures can be specified in the main model file

Additional context

This issue is related to a case-specific application of AixLib (ROM) and TEASER which also includes issue #679 in TEASER (others may follow after email consultations)

@LauraMaier
Copy link
Contributor

@PGorzalka: Are you working or intend to work on this issue yourself? Otherwise, we will discuss it on hackday.

@PGorzalka
Copy link
Author

@DaJansenGit already received some code from me that I intended to contribute here later this month. If he doesn't object, I think that would cover the issue.

@DaJansenGit DaJansenGit self-assigned this Oct 20, 2021
@DaJansenGit DaJansenGit added this to the Hackday 10.2021 milestone Oct 20, 2021
@DaJansenGit DaJansenGit removed this from the Hackday 10.2021 milestone Oct 22, 2021
@tobinfiedler
Copy link
Contributor

@DaJansenGit @PGorzalka What is the current status of this issue?

@PGorzalka
Copy link
Author

@tobinfiedler @DaJansenGit sorry I didn't come back to this; had other projects I was working on. However, as my PhD exam approaches it would be nice to have the code I wrote as part of the PhD project finally contributed here. That's the code mentioned in May last year. It covers several other topics, but this one could be a good starting point for the contribution. As it requires some extra work from my side (my fork of AixLib is pretty old): How urgently do you need it?

@DaJansenGit
Copy link
Member

The long delay here is on me. I still need to give your models a detailed look @PGorzalka. But since the review is also a more comprehensive change, it's still on my list. Maybe we can schedule a meeting in December to discuss the next steps? I will then have a look at the changes beforehand. Hard deadlines usually help at least on my side 😆

@FelixStege
Copy link
Contributor

Any updates on this? @DaJansenGit @PGorzalka

@PGorzalka
Copy link
Author

PGorzalka commented Feb 15, 2023

@FelixStege not yet. @DaJansenGit didn't manage to schedule a meeting last year... If you're working on the topic, maybe we could arrange one together?
My PhD thesis was delayed by RWTH-internal issues, but hopefully finish with the exam this year. So I still got the motivation mentioned above.

@DaJansenGit
Copy link
Member

DaJansenGit commented Mar 8, 2023

Discussion results

@PGorzalka and I had a discussion about the changes that makes sense. Following you can find the results.

Required changes

ThermalZone

  • Move soilt temperature calculation into a submodel that is placed in ThermalZone
  • We provide four options:
    • constant value (default and current state)
    • sinus curve
    • table
    • optional: EPW (energyplus) weather file which provides weekly? ground temperature data in header (these data might be removed from our weather conversion tool)
  • Changes due to interzonal heat transfer like the average temperature of soil and neighborhood zones (currently named addNZsAndSoil will be not implemented in this issue

ZoneParams

  • This requires additional parameters in zoneParam (not including weather file option)
    • amplitude for sinus curve
    • offset (but this might also be fixed)
    • table file reference

@PGorzalka
Copy link
Author

Further notes on discussion results

  • EPW files provides ground properties and monthly average ground temperatures in variable depths. A definition can be found here.
  • additionally, envisaged contributions include
    • interzonal heat exchange (TEASER and AixLib)
    • custom template paths for Modelica output in TEASER (see issue 679 there)
    • a new possibility to estimate interior wall area

@DaJansenGit
Copy link
Member

This was closed due a merge into IPBSA (ibpsa/modelica-ibpsa#1790)

@DaJansenGit
Copy link
Member

We will keep this open until the next IBPSA merge is done.

@PGorzalka
Copy link
Author

@DaJansenGit I created PR #1546 for this which now includes interzonal heat transfer. If you'd prefer splitting the two, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants