Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kingamadej 80 takeoff detection #81

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Kingamadej 80 takeoff detection #81

wants to merge 5 commits into from

Conversation

kingamadej
Copy link
Contributor

I wrote some code that aims to detect takeoff. The idea is to detect when acceleration vector changes - when it goes upwards.

@kingamadej kingamadej linked an issue Aug 11, 2023 that may be closed by this pull request
Takeoff detection #80
Open
Bartosz-Slowik
Bartosz-Slowik requested changes Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@Bartosz-Slowik Bartosz-Slowik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few issues.

  1. this will trigger if at ANY point during the installation into the rocket the cansat is tilted/rotated.
  2. this should be in a separate function.
  3. I think match would be better than this if/else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bartosz-Slowik Bartosz-Slowik Bartosz-Slowik requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@kingamadej kingamadej

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Takeoff detection
2 participants
@kingamadej @Bartosz-Slowik