Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ingester.QueryStream: Add support for ignoring context cancellation for chunk queriers #6408

Merged
merged 15 commits into from
Oct 19, 2023
Merged

Ingester.QueryStream: Add support for ignoring context cancellation for chunk queriers #6408

merged 15 commits into from
Oct 19, 2023

Commits on Oct 18, 2023

  1. Ingester.QueryStream: Ignore context cancellation for chunk queriers 

    In Ingester.QueryStream, ignore context cancellation wrt. chunk
queriers, the way it worked prior to
#6085. If the context is canceled
though, log it with full diagnostics.

Signed-off-by: Arve Knudsen <[email protected]>
    @aknuds1
    aknuds1 committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    998948e View commit details
    Browse the repository at this point in the history

  2. Ingester.QueryStream: Pass independent context for chunk queriers 

    Signed-off-by: Arve Knudsen <[email protected]>
    @aknuds1
    aknuds1 committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    2cffe7a View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into arve/chunk-query-igno… 

    …re-ctx
    @aknuds1
    aknuds1 committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    48e51b3 View commit details
    Browse the repository at this point in the history

  4. Let dumpContextError figure out timeout 

    Signed-off-by: Arve Knudsen <[email protected]>
    @aknuds1
    aknuds1 committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    dee03b6 View commit details
    Browse the repository at this point in the history

  5. Improve error messages 

    Signed-off-by: Arve Knudsen <[email protected]>
    @aknuds1
    aknuds1 committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    c53f8be View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/main' into arve/chunk-query-igno… 

    …re-ctx
    @aknuds1
    aknuds1 committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    04fc5d4 View commit details
    Browse the repository at this point in the history

  7. dumpContextError: Log with debug level instead of warn 

    Signed-off-by: Arve Knudsen <[email protected]>
    @aknuds1
    aknuds1 committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    1885ca5 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. Merge remote-tracking branch 'origin/main' into arve/chunk-query-igno… 

    …re-ctx
    @aknuds1
    aknuds1 committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    173acb0 View commit details
    Browse the repository at this point in the history

  2. Put functionality behind flag 

    Signed-off-by: Arve Knudsen <[email protected]>
    @aknuds1
    aknuds1 committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    6b1323e View commit details
    Browse the repository at this point in the history

  3. Add changelog entry 

    Signed-off-by: Arve Knudsen <[email protected]>
    @aknuds1
    aknuds1 committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    27644b0 View commit details
    Browse the repository at this point in the history

  4. Fix comparison 

    Signed-off-by: Arve Knudsen <[email protected]>
    @aknuds1
    aknuds1 committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    4b8e651 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/main' into arve/chunk-query-igno… 

    …re-ctx
    @aknuds1
    aknuds1 committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    6d9b694 View commit details
    Browse the repository at this point in the history

  6. Use context.WithoutCancel 

    Signed-off-by: Arve Knudsen <[email protected]>
    @aknuds1
    aknuds1 committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    c942adf View commit details
    Browse the repository at this point in the history

  7. Remove experimental from help text 

    Signed-off-by: Arve Knudsen <[email protected]>
    @aknuds1
    aknuds1 committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    76a30ea View commit details
    Browse the repository at this point in the history

  8. Document feature better 

    Signed-off-by: Arve Knudsen <[email protected]>
    @aknuds1
    aknuds1 committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    96557ef View commit details
    Browse the repository at this point in the history