Add counter reset test for mmapped OOO chunks #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fionaliao
force-pushed
the
fl/counter-reset-write-test
branch
2 times, most recently
from
122e405
to
fd306a4
Compare
Fixed a couple of bugs that were discovered while writing the test: - mint for ooo chunk needed to be set when a new chunk was created - first chunk was using the wrong previous appender Signed-off-by: Fiona Liao <[email protected]>
fionaliao
force-pushed
the
fl/counter-reset-write-test
branch
2 times, most recently
from
1d88073
to
bfe650a
Compare
fionaliao
force-pushed
the
fl/counter-reset-write-test
branch
from
bfe650a
to
8061c62
Compare
fionaliao
added a commit
that referenced
this pull request
Nov 29, 2023
* Add counter reset test for mmapped OOO chunks Fixed a couple of bugs that were discovered while writing the test: - mint for ooo chunk needed to be set when a new chunk was created - first chunk was using the wrong previous appender Signed-off-by: Fiona Liao <[email protected]> * nolint:staticcheck --------- Signed-off-by: Fiona Liao <[email protected]>
carrieedwards
pushed a commit
that referenced
this pull request
Jan 8, 2024
* Add counter reset test for mmapped OOO chunks Fixed a couple of bugs that were discovered while writing the test: - mint for ooo chunk needed to be set when a new chunk was created - first chunk was using the wrong previous appender Signed-off-by: Fiona Liao <[email protected]> * nolint:staticcheck --------- Signed-off-by: Fiona Liao <[email protected]>
carrieedwards
pushed a commit
that referenced
this pull request
Jan 9, 2024
* Add counter reset test for mmapped OOO chunks Fixed a couple of bugs that were discovered while writing the test: - mint for ooo chunk needed to be set when a new chunk was created - first chunk was using the wrong previous appender Signed-off-by: Fiona Liao <[email protected]> * nolint:staticcheck --------- Signed-off-by: Fiona Liao <[email protected]>
carrieedwards
pushed a commit
that referenced
this pull request
Jan 9, 2024
* Add counter reset test for mmapped OOO chunks Fixed a couple of bugs that were discovered while writing the test: - mint for ooo chunk needed to be set when a new chunk was created - first chunk was using the wrong previous appender Signed-off-by: Fiona Liao <[email protected]> * nolint:staticcheck --------- Signed-off-by: Fiona Liao <[email protected]>
fionaliao
added a commit
that referenced
this pull request
Jan 19, 2024
* Add counter reset test for mmapped OOO chunks Fixed a couple of bugs that were discovered while writing the test: - mint for ooo chunk needed to be set when a new chunk was created - first chunk was using the wrong previous appender Signed-off-by: Fiona Liao <[email protected]> * nolint:staticcheck --------- Signed-off-by: Fiona Liao <[email protected]>
fionaliao
added a commit
that referenced
this pull request
Jan 23, 2024
* Add counter reset test for mmapped OOO chunks Fixed a couple of bugs that were discovered while writing the test: - mint for ooo chunk needed to be set when a new chunk was created - first chunk was using the wrong previous appender Signed-off-by: Fiona Liao <[email protected]> * nolint:staticcheck --------- Signed-off-by: Fiona Liao <[email protected]>
fionaliao
added a commit
that referenced
this pull request
Feb 5, 2024
* Add counter reset test for mmapped OOO chunks Fixed a couple of bugs that were discovered while writing the test: - mint for ooo chunk needed to be set when a new chunk was created - first chunk was using the wrong previous appender Signed-off-by: Fiona Liao <[email protected]> * nolint:staticcheck --------- Signed-off-by: Fiona Liao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a couple of bugs that were discovered while writing the test: