[WIP] Counter reset test for mmapped OOO chunks #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeanette Tan <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
First version of the code. WIP. Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
Now we can use nil, since we're returning a slice. Fixes broken TestOOOCompactionWithDisabledWriteLog Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
This is the dumb copy paste implementation to get tests to pass. Signed-off-by: György Krajcsovits <[email protected]>
Test with integer and float histograms Counter only. Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
OOOHeadChunk yields a single encoded chunk. Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
Probably replicating some code here, this can't be the first place for this. Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
…grams merge main
Signed-off-by: György Krajcsovits <[email protected]>
# Conflicts: # tsdb/querier.go
Adopt prometheus#12352 improvement. Signed-off-by: György Krajcsovits <[email protected]>
…grams megre main and update ooo_head
Signed-off-by: Jeanette Tan <[email protected]>
Signed-off-by: Jeanette Tan <[email protected]>
Fix handling of native histogram encoding in OOO chunks
Signed-off-by: Shirley Leu <[email protected]> Co-authored-by: Fiona Liao <[email protected]>
* Benchmark WBL Extended WAL benchmark test with WBL parts too - added basic cases for OOO handling - a percentage of series have a percentage of samples set as OOO ones. Signed-off-by: Fiona Liao <[email protected]>
Signed-off-by: Fiona Liao <[email protected]>
Signed-off-by: Fiona Liao <[email protected]>
Signed-off-by: Fiona Liao <[email protected]>
Signed-off-by: Fiona Liao <[email protected]>
Signed-off-by: Fiona Liao <[email protected]>
Signed-off-by: Fiona Liao <[email protected]>
fionaliao
force-pushed
the
fl/counter-reset-tests
branch
from
5c5011b
to
0d8f62b
Compare
fionaliao
force-pushed
the
fl/counter-reset-tests
branch
from
0d8f62b
to
39ee6ec
Compare
carrieedwards
force-pushed
the
ooo-native-histogram-tests
branch
from
0b00227
to
be7fa6b
Compare
|
Closed, PR moved to grafana/mimir-prometheus#544 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready for review yet - test is basically complete but waiting for prometheus@b6f903b to be merged in as some assertions are currently failing due to the bug that commit fixes.
Fixed a couple of bugs