Fix issue where chainSampleIterator can obscure errors
#540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…errors Signed-off-by: Charles Korn <[email protected]>
Do you mean "... and therefore not check |
|
English is ambiguous :) I've tried to make it clearer. |
Signed-off-by: Charles Korn <[email protected]>
charleskorn
changed the title
chainSampleIterator.Seek() can obscure errorschainSampleIterator can obscure errors
2 tasks
jhalterman
approved these changes
Oct 12, 2023
charleskorn
added a commit
to grafana/mimir
that referenced
this pull request
Oct 12, 2023
This brings in the fix from grafana/mimir-prometheus#540.
1 task
charleskorn
added a commit
to grafana/mimir
that referenced
this pull request
Oct 12, 2023
* Upgrade mimir-prometheus This brings in the fix from grafana/mimir-prometheus#540. * Add changelog entry
👍 |
This was referenced Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If any iterator in a
chainSampleIteratorhas a sample after the desired timestamp whenSeek()is called,Seek()will not returnValNone.If some iterators have failed (ie. calling
innerIterator.Err()returns a non-nilvalue) and others have not, this behaviour may hide errors from those iterators: callers ofSeek()will not receiveValNoneand therefore won't know to checkchainSampleIterator.Err().Next()is susceptible to a similar issue ifNext()is not called until the stream is completely exhausted.I'll submit this fix upstream once we've tested Mimir with it.