Fix issue where concatenatingChunkIterator can obscure errors.
#549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charles Korn <[email protected]>
jhesketh
approved these changes
Oct 23, 2023
aknuds1
approved these changes
Oct 23, 2023
dimitarvdimitrov
approved these changes
Oct 23, 2023
1 task
|
Reverted in #562. |
krajorama
added a commit
to grafana/mimir
that referenced
this pull request
Nov 6, 2023
For grafana/mimir-prometheus#562 revert of grafana/mimir-prometheus#549 Ref: #incident-2023-11-06-cortex-ops-01-block-to-the-future Signed-off-by: György Krajcsovits <[email protected]>
krajorama
added a commit
to grafana/mimir
that referenced
this pull request
Nov 6, 2023
For grafana/mimir-prometheus#562 revert of grafana/mimir-prometheus#549 Ref: #incident-2023-11-06-cortex-ops-01-block-to-the-future Signed-off-by: György Krajcsovits <[email protected]>
grafanabot
pushed a commit
to grafana/mimir
that referenced
this pull request
Nov 6, 2023
For grafana/mimir-prometheus#562 revert of grafana/mimir-prometheus#549 Ref: #incident-2023-11-06-cortex-ops-01-block-to-the-future Signed-off-by: György Krajcsovits <[email protected]> (cherry picked from commit 4987dd5)
krajorama
added a commit
to grafana/mimir
that referenced
this pull request
Nov 6, 2023
For grafana/mimir-prometheus#562 revert of grafana/mimir-prometheus#549 Ref: #incident-2023-11-06-cortex-ops-01-block-to-the-future Signed-off-by: György Krajcsovits <[email protected]> (cherry picked from commit 4987dd5)
grafanabot
pushed a commit
to grafana/mimir
that referenced
this pull request
Nov 6, 2023
For grafana/mimir-prometheus#562 revert of grafana/mimir-prometheus#549 Ref: #incident-2023-11-06-cortex-ops-01-block-to-the-future Signed-off-by: György Krajcsovits <[email protected]> (cherry picked from commit 4987dd5)
krajorama
added a commit
to grafana/mimir
that referenced
this pull request
Nov 6, 2023
For grafana/mimir-prometheus#562 revert of grafana/mimir-prometheus#549 Ref: #incident-2023-11-06-cortex-ops-01-block-to-the-future Signed-off-by: György Krajcsovits <[email protected]> (cherry picked from commit 4987dd5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a similar issue to #540, but this time for
concatenatingChunkIterator: if a consumer of aconcatenatingChunkIteratordoes not consume it all the way to the end (ie. untilNext()returnsfalse), it may not know to check for an error.With this PR,
concatenatingChunkIterator.Next()will instead begin returningfalseas soon as the current iterator reports an error.