Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(github-metrics): Default teams to be empty array #669

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

@hubertdeng123
Copy link
Member Author

hubertdeng123 commented Oct 23, 2023

I guess my dev schema I was testing with was slightly different than in prod, since mine was nullable...

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/utils/metrics.ts 76.64% <ø> (ø)

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@azaslavsky azaslavsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this to unblock, but it doesn't seem like the schema changed anywhere? Is there anywhere that defines the common schema used in both test and prod? Put another way: I think this PR fixes the symptom (schema drift), but not the cause (there are separate schemas defined for prod and testing, making it very likely that they'll drift again).

@hubertdeng123
Copy link
Member Author

I think a more permanent solution involves creating a dev BigQuery instance that is accessibly by everyone that is synced with the prod schema. Right now I'm using my own GCP project as a dev instance since I don't have access to the dev environment project that has been used in the past.

@hubertdeng123 hubertdeng123 merged commit f95a7ca into main Oct 23, 2023
8 checks passed
@hubertdeng123 hubertdeng123 deleted the hubertdeng123/fix-teams-null branch October 23, 2023 16:47
@hubertdeng123
Copy link
Member Author

There is not a place where a common schema is used both in test and prod, but that'd be super nice to have.

Created an issue: #670

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants